Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] Fix display of empty state view in clear cache #44349

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

Quy
Copy link
Contributor

@Quy Quy commented Oct 23, 2024

Pull Request for Issue #44247 .

Summary of Changes

PR #38671 did not account for search filter to be null when not using search, thus, won't display the empty state view when the cache folder is empty.

Testing Instructions

Go to System > Clear Cache.
See empty state view when the cache folder is empty.

@fontanil
Copy link

Hi,
Successfully tested on Joomla! 5.2.0
Thank you

@fgsw
Copy link

fgsw commented Oct 24, 2024

@fontanil Can you open https://issues.joomla.org/tracker/joomla-cms/44349 and

  • click button "Test this"
  • mark "Tested successfully"

The test will count as successfull.

@fontanil
Copy link

I have tested this item ✅ successfully on 0cb0e40

Successfully tested on5.2.0
Thanks!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44349.

@uGE70
Copy link

uGE70 commented Oct 24, 2024

I have tested this item ✅ successfully on 0cb0e40

Thanks a lot. My test site was using Gantry. It doesn't happen on Cassiopeia, because there's the _media_version folder.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44349.

@Quy Quy added the bug label Oct 24, 2024
@Quy
Copy link
Contributor Author

Quy commented Oct 24, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44349.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Oct 24, 2024
@wilsonge wilsonge merged commit 9f3bec7 into joomla:5.2-dev Oct 25, 2024
3 checks passed
@wilsonge
Copy link
Contributor

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Oct 25, 2024
@wilsonge wilsonge modified the milestones: Joomla! 5.3.0, Joomla! 5.2.1 Oct 25, 2024
@Quy Quy deleted the 44247-cache-empty-state branch October 25, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants