Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emptystate layout is used for non-empty cache #38671

Merged
merged 5 commits into from
May 4, 2023
Merged

Conversation

Denitz
Copy link
Contributor

@Denitz Denitz commented Sep 2, 2022

Summary of Changes

"You have no cached content." is displayed after deleting the filtered cache group.

Testing Instructions

  1. Ensure that Joomla caching is enabled, load frontend as guest
  2. Go to Maintenance > Clear Cache in backend
  3. Filter by any frontend-specific cache group, i.e. com_content in search field.
  4. See single group filtered
  5. Delete it
  6. See "You have no cached content." layout without search field.

Actual result BEFORE applying this Pull Request

Frustrating "You have no cached content." message on active search filter applied though we have non-filtered cache groups.
Search field is not visible.

Expected result AFTER applying this Pull Request

See the usual empty table with "No Matching Results" message and visible search input.

Documentation Changes Required

No.

@brianteeman
Copy link
Contributor

I can confirm the issue.

Just wondering why its not the same as all the other emptystate with $this->get('IsEmptyState')

@Denitz
Copy link
Contributor Author

Denitz commented Sep 5, 2022

@brianteeman Because ListModel::getIsEmptyState() uses a database query but com_cache is "databaseless" :)

@brianteeman
Copy link
Contributor

Ok. Thanks for the explanation

@brianteeman
Copy link
Contributor

tested ok

Its marked as an issue on the tracker so cant post a result there

@Hackwar Hackwar added the Small A PR which only has a small change label Feb 26, 2023
@Denitz Denitz changed the base branch from 4.2-dev to 4.3-dev March 24, 2023 20:55
@Quy
Copy link
Contributor

Quy commented Mar 25, 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38671.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 25, 2023
@Hackwar Hackwar added the bug label Apr 6, 2023
@obuisard obuisard added this to the Joomla! 4.3.2 milestone May 4, 2023
@obuisard obuisard merged commit 80b51cb into joomla:4.3-dev May 4, 2023
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 4, 2023
@obuisard
Copy link
Contributor

obuisard commented May 4, 2023

Thank you @Denitz :-)

@Denitz
Copy link
Contributor Author

Denitz commented May 4, 2023

Thank you! 1-line patch in 10 months, even after Brian's confirmation :(

@laoneo
Copy link
Member

laoneo commented Oct 25, 2024

And this one line had a bug :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Small A PR which only has a small change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants