Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Article edit tabs and fields #44246

Open
wants to merge 9 commits into
base: 5.2-dev
Choose a base branch
from

Conversation

chmst
Copy link
Contributor

@chmst chmst commented Oct 14, 2024

Pull Request for Issue #44118 .

Summary of Changes

This PR re-arranges fields and tabs in frontend edit for articles.
It moves all options which are in the right sidbar of articles to a new tab "options"
It writes all fields which are in the publishing tab of the article into the publishing tab.
This removes the language tab and the metadata tab.

Testing Instructions

Compare the edit form for an article before and after the PR. Make sure that different user groups witrh different permissions have the same fields before and after the pr.
Swith on and off the show_publishing_data in articles options. on: publishing tab exists, off: no publishing data.

Actual result BEFORE applying this Pull Request

see #44118

Expected result AFTER applying this Pull Request

grafik
grafik

REMARK
It would be correct to use a new param for switching on and off the publishing tab. But this would be a b/c break.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added the Language Change This is for Translators label Oct 16, 2024
@fgsw
Copy link

fgsw commented Oct 17, 2024

I have tested this item ✅ successfully on 7e079b9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44246.

Comment on lines 118 to 122
<div class="control-label">
</div>
<div class="controls">
<?php echo Text::_('COM_CONTENT_ORDERING'); ?>
</div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<div class="control-label">
</div>
<div class="controls">
<?php echo Text::_('COM_CONTENT_ORDERING'); ?>
</div>
<div class="control-label">
</div>
<div class="controls">
<?php echo Text::_('COM_CONTENT_ORDERING'); ?>
</div>

Please check. Empty div and string in controls div?

Copy link
Contributor Author

@chmst chmst Oct 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx, this is completely wrong, but not quite in scope of this PR.
It displays a description

grafik

My impulse is to remove the whole field from frontend editing. What's your opinion?

@fgsw
Copy link

fgsw commented Oct 19, 2024

@chmst Can the ordering of fields be the same between Back- and Frontend:

Tab "Options"

Backend Frontend
options-backend options-frontend

Tab "Publishing"

Backend Frontend
publishing-backend publishing-frontend

@chmst
Copy link
Contributor Author

chmst commented Oct 19, 2024

Changed the ordering of fields as suggested by @fgsw , added a fieldset and legend to metadata (ux, a11y)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators PR-5.2-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants