-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publishing tab still shows #44118
Comments
@Webdongle #37816 related?
yes Originally posted by @brianteeman in #37816 (comment) |
Yes I see that reasoning. However the 'Publish' field should also be hidden with the 'Start Publishing' etc.? Also the Options field could read 'Hide publishing Options' rather than 'Hide Publishing tab'? Perhaps close in favour of #37816 ? |
Can you check if there is a difference here between j4 and j5 |
|
Doesn't look like any difference to me. Have a look at the screenshots please. Does that look the same as J5 to you? |
Your screenshots are both for j4 |
Yes and when I compare them to J5 they look the same. When you have J5 up and compare them to the J4 screenshots do they look the same to you? |
Can reproduce in J5 as well |
What needs to be done here? Instead of the Option to Show or Hide "Publishing Options" maybe "Publishing Date fields" ? |
Not a programmer but I think this solves the problem in "components\com_content\tmpl\form\edit.php"
|
Yes I know, that's what I am asking if there was any reason putting it in the condition. and what needs to be done, then I create a PR |
@coolcat-creations : Edited my previous contribution. Think this solves it. |
Just found out that when doing this, one is unable to select category (which is located in publishing tab.
|
Where did you set the param, @Webdongle? I cannot find any param for for the frontend. I would see this as a bug in frontend edit screen. |
@chmst where is that text from? I would say that the text is wrong for both publishing and article options and that text and its use of the word TAB are what is causing the confusion. For me everything is working exactly as it was designed |
@brianteeman @chmst @brianteeman Says that is as expected. So if that is the way it is supposed to work then we have to work with it and hope someone can update the help docs. Spot the difference Addendum |
Should we just clean up these options a bit and add options for frontend and backend and make everything more clear? |
I have prepared a PR with a re-arrangement of fields and tabs. Will commit when I am back on my laptop. But I disagree with changing the docs. All these switches are only for backend and it is not consistent that one of them is for backend and frontend, the others are not. What we have now is not consistent from usability point of view |
But the Help screen says the switch is for admin when the switch actually alters fields and removes a whole tab from the edit screen in the front end. Perhaps the questions should be: |
This is the question, but I have no answer. Please test the PR #44246 if this is convenient. |
the help screen is simply wrong. the code is correct |
If the code is correct, then the help screen is wrong. Fact is, that the edit screen is confusing, because general article options and publishing Option are mixed in one tab. |
I do not understand why you have the featured field in one tab but Start Featured and Finish Featured in a different tab |
Check the history of the code. That gives you the answer |
I stop here. Who wants can test the PR or make an aternative PR and who wants can contine this useless discussion. |
Where is the PR @chmst :-) |
thank you :-) |
Steps to reproduce the issue
In Article Options >>> Editing Layout (tab) ...Publishing options Hide
Login front end as Super User (or as as user with 'Edit State')
Expected result
The 'Publishing' tab does not show
Actual result
The 'Publishing' tab shows but the 'Metadata' tab does not show
System information (as much as possible)
Additional comments
The text was updated successfully, but these errors were encountered: