Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] [feature] Media manager select last uploaded item (iframe) #43823

Merged
merged 9 commits into from
Jul 26, 2024

Conversation

dgrammatiko
Copy link
Contributor

Pull Request for Issue # .

Summary of Changes

  • Select the last uploaded file when media manager is inside an iframe (ie, when selecting an image in a media field or inside an editor)

Testing Instructions

  • Create a new article
  • Select an intro image
  • navigate to any folder
  • Upload an image

The image should be selected

Repeat the same with the CMS Content->Media button in tinyMCE editor

Repeat the same with the media button bellow the Codemirror

Actual result BEFORE applying this Pull Request

The file was not selected after upload, user needed to pick the file manually

Expected result AFTER applying this Pull Request

The file is selected after upload, user needed to pick the file manually

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@Quy
Copy link
Contributor

Quy commented Jul 22, 2024

Clicking Select or Insert Media button does not insert the image. You have to reselect the image, then the button will work.

@dgrammatiko
Copy link
Contributor Author

Clicking Select or Insert Media button does not insert the image. You have to reselect the image, then the button will work.

What's your browser? Seems to work on Webkit (I only tested it there)

@Quy
Copy link
Contributor

Quy commented Jul 22, 2024

Firefox 128.0 and Chrome Version 126.0.6478.128 on Windows

@brianteeman
Copy link
Contributor

Confirming the results from @Quy

Chrome Windows - Version 126.0.6478.128 (Official Build) (64-bit)

@brianteeman
Copy link
Contributor

I have tested this item 🔴 unsuccessfully on b3c304d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43823.

@Fedik
Copy link
Member

Fedik commented Jul 22, 2024

@dgrammatiko User selection happen on click, then that "select event" is triggered

@Fedik Fedik added the Feature label Jul 22, 2024
@dgrammatiko
Copy link
Contributor Author

User selection happen on click, then that "select event" is triggered

I'm NOT doing an automatic insertion of the uploaded image, I just set the state of the selected file! (means the user still needs to press the insert button, but in this case the file is already selected no need to search for it...) BTW the issue was about SELECTING the image not automatically inserting it, that's a different case

@dgrammatiko
Copy link
Contributor Author

@Quy @brianteeman should be ok for all browsers now (tested with Chrome, Webkit, FF)

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on f669b9f

works as intended now - thanks


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43823.

@Quy
Copy link
Contributor

Quy commented Jul 22, 2024

I have tested this item ✅ successfully on f669b9f

Thank you!!!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43823.

@Quy
Copy link
Contributor

Quy commented Jul 22, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43823.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jul 22, 2024
@dgrammatiko
Copy link
Contributor Author

Just a note for the person that would merge this PR: please merge first PR #43579 and then this one.

@laoneo
Copy link
Member

laoneo commented Jul 26, 2024

I have tested this item ✅ successfully on d357b4c

Tested image in editor and intro image. Also with the DPMedia restricted plugin.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43823.

@Hackwar
Copy link
Member

Hackwar commented Jul 26, 2024

@Quy @brianteeman could you test this again? There were some changes lately and we are missing one more test.

@Quy
Copy link
Contributor

Quy commented Jul 26, 2024

I have tested this item ✅ successfully on 0d98552


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43823.

@Hackwar Hackwar merged commit 5b8073c into joomla:5.2-dev Jul 26, 2024
4 checks passed
@Hackwar Hackwar added this to the Joomla! 5.2.0 milestone Jul 26, 2024
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jul 26, 2024
@Hackwar
Copy link
Member

Hackwar commented Jul 26, 2024

Thank you for your contribution @dgrammatiko! 😊

@dgrammatiko dgrammatiko deleted the patch-2 branch July 26, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.2-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants