-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.2] [feature] Media manager select last uploaded item (iframe) #43823
Conversation
Clicking |
What's your browser? Seems to work on Webkit (I only tested it there) |
Firefox 128.0 and Chrome Version 126.0.6478.128 on Windows |
Confirming the results from @Quy Chrome Windows - Version 126.0.6478.128 (Official Build) (64-bit) |
I have tested this item 🔴 unsuccessfully on b3c304d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43823. |
@dgrammatiko User selection happen on click, then that "select event" is triggered |
I'm NOT doing an automatic insertion of the uploaded image, I just set the state of the selected file! (means the user still needs to press the insert button, but in this case the file is already selected no need to search for it...) BTW the issue was about |
@Quy @brianteeman should be ok for all browsers now (tested with Chrome, Webkit, FF) |
I have tested this item ✅ successfully on f669b9f This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43823. |
I have tested this item ✅ successfully on f669b9f This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43823. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43823. |
Just a note for the person that would merge this PR: please merge first PR #43579 and then this one. |
I have tested this item ✅ successfully on d357b4c This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43823. |
@Quy @brianteeman could you test this again? There were some changes lately and we are missing one more test. |
I have tested this item ✅ successfully on 0d98552 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43823. |
Thank you for your contribution @dgrammatiko! 😊 |
Pull Request for Issue # .
Summary of Changes
Testing Instructions
The image should be selected
Repeat the same with the CMS Content->Media button in tinyMCE editor
Repeat the same with the media button bellow the Codemirror
Actual result BEFORE applying this Pull Request
The file was not selected after upload, user needed to pick the file manually
Expected result AFTER applying this Pull Request
The file is selected after upload, user needed to pick the file manually
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed