Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix chevron color in module menu assignment #43645

Merged
merged 4 commits into from
Jun 18, 2024
Merged

Conversation

RickR2H
Copy link
Member

@RickR2H RickR2H commented Jun 12, 2024

Pull Request for Issue # .

Summary of Changes

The chevron in the Module menu Assignment in light mode is not visible. In dark mode the chevron is visible.

module-light-mode
module-dark-mode

I used the default link color as new color.

Testing Instructions

  • Checkout this PR and build the CSS with: npm run build:css
  • Set the template to light mode
  • Check if the chevron is visible

Actual result BEFORE applying this Pull Request

Chevron not visible

Expected result AFTER applying this Pull Request

Chevron is visible

module-light-mode-fixed

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.2-dev labels Jun 12, 2024
Added empty line at the end
@Quy
Copy link
Contributor

Quy commented Jun 12, 2024

I have tested this item ✅ successfully on 8cc4aaf


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43645.

1 similar comment
@carlitorweb
Copy link
Member

I have tested this item ✅ successfully on 8cc4aaf


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43645.

@Quy
Copy link
Contributor

Quy commented Jun 12, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43645.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jun 12, 2024
@brianteeman
Copy link
Contributor

Something sees odd here - the css being changed was only recently added #43160

Did not work then (we need to improve our testing) or has another PR somewhere else changed the behaviour

@RickR2H RickR2H closed this Jun 13, 2024
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jun 13, 2024
@RickR2H
Copy link
Member Author

RickR2H commented Jun 13, 2024

PR is closed due to some solution is merged already #43160.

@brianteeman
Copy link
Contributor

This PR is needed.

Did not work then (we need to improve our testing) or has another PR somewhere else changed the behaviour

@RickR2H RickR2H reopened this Jun 13, 2024
@RickR2H
Copy link
Member Author

RickR2H commented Jun 13, 2024

@brianteeman Re-opened

@RickR2H
Copy link
Member Author

RickR2H commented Jun 13, 2024

Was closed before so the successful tests where reset. No code has been changed so added the tests and RTC status again.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43645.

@joomla-cms-bot joomla-cms-bot added RTC This Pull Request is Ready To Commit and removed RTC This Pull Request is Ready To Commit labels Jun 13, 2024
@RickR2H
Copy link
Member Author

RickR2H commented Jun 13, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43645.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jun 13, 2024
@pe7er pe7er self-assigned this Jun 18, 2024
@pe7er pe7er merged commit 167dcbc into joomla:5.2-dev Jun 18, 2024
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jun 18, 2024
@pe7er
Copy link
Contributor

pe7er commented Jun 18, 2024

Thanks @RickR2H !

@RickR2H RickR2H deleted the fix-chevron branch June 18, 2024 08:14
@Quy Quy added this to the Joomla! 5.2.0 milestone Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.2-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants