Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] Dark Mode menu select toggle colour #43160

Merged
merged 2 commits into from
Mar 27, 2024
Merged

Conversation

brianteeman
Copy link
Contributor

final part Pull Request for Issue #43068 .

Summary of Changes

Change the colour of the icon in the treeselect for assigning modules to pages to satisfy contrast rules

Testing Instructions

see #43068 for more details

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.1-dev labels Mar 26, 2024
@Quy Quy added the Dark Mode label Mar 26, 2024
@Quy
Copy link
Contributor

Quy commented Mar 26, 2024

I have tested this item ✅ successfully on d9bd44a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43160.

@Quy Quy added the a11y Accessibility label Mar 26, 2024
@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on d9bd44a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43160.

@Quy
Copy link
Contributor

Quy commented Mar 26, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43160.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 26, 2024
@LadySolveig LadySolveig added this to the Joomla! 5.1.0 milestone Mar 27, 2024
@LadySolveig LadySolveig merged commit bc2161b into joomla:5.1-dev Mar 27, 2024
3 checks passed
@LadySolveig
Copy link
Contributor

Thank you @brianteeman and also for testing @viocassel @Quy

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 27, 2024
@brianteeman
Copy link
Contributor Author

thanks

@RickR2H
Copy link
Member

RickR2H commented Jun 13, 2024

@brianteeman I commited to the 5.2 branch. I think you PR was not up-merged. That why I didn't notice it. I'll close my PR and I'll wait for the up-merge.

@brianteeman
Copy link
Contributor Author

No your PR is needed. This was upmerged but

Did not work then (we need to improve our testing) or has another PR somewhere else changed the behaviour

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Accessibility Dark Mode NPM Resource Changed This Pull Request can't be tested by Patchtester
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants