-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.1] Dark Mode menu select toggle colour #43160
Conversation
I have tested this item ✅ successfully on d9bd44a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43160. |
I have tested this item ✅ successfully on d9bd44a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43160. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43160. |
Thank you @brianteeman and also for testing @viocassel @Quy |
thanks |
@brianteeman I commited to the 5.2 branch. I think you PR was not up-merged. That why I didn't notice it. I'll close my PR and I'll wait for the up-merge. |
No your PR is needed. This was upmerged but
|
final part Pull Request for Issue #43068 .
Summary of Changes
Change the colour of the icon in the treeselect for assigning modules to pages to satisfy contrast rules
Testing Instructions
see #43068 for more details
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed