Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[email protected] untested ⚠️ #77

Closed
wants to merge 1 commit into from

Conversation

greenkeeperio-bot
Copy link
Contributor

🚨🔥⚠️ Action required: Switch to the new Greenkeeper now! 🚨🔥⚠️
This version of Greenkeper will be shutdown on May 31st.
With Integrations first-class bot support landed on GitHub and we’ve rewritten Greenkeeper to take full advantage of it. Simpler setup, fewer pull-requests, faster than ever.


Hello lovely humans,

browser-sync just published its new version 2.18.11.

State No tests ⚠️
Dependency browser-sync
New version 2.18.11
Type devDependency

This version is covered by your current version range, but I could not detect automated tests for this project. Without a test suite I can not really tell whether your project still works.

I was looking at the latest commit of your default branch, but GitHub said there is no status attached to it.

Do you have any ideas how I could improve these pull requests? Did I report anything you think isn’t right?
Are you unsure about how things are supposed to work?

There is a collection of frequently asked questions and while I’m just a bot, there is a group of people who are happy to teach me new things. Let them know.

Good luck with your project ✨

You rock!

🌴


GitHub Release

FIXED Source map files are now ignored by default. c990ea2

Previously, if you were watching a directory into which source maps were being written (alongside your CSS/JS etc) then Browsersync would instruct all browsers to actually RELOAD as it wouldn't know how to handle the 'map' files.

This was particularly frustrating for gulp users - take this following example (where we compile sass-> css)

gulp.task('styles', function() {
  return gulp.src('app/core.scss')
      .pipe(sourcemaps.init())
      .pipe(sass())
      .pipe(sourcemaps.write('.'))
      .pipe(gulp.dest('dist'))
      .pipe(browserSync.stream())
});

With this, each time a file is saved, there would be 2 output files core.css & core.css.map and Browsersync would be informed of both. With the CSS file, it would update any references to that file in all connected browsers, but for the map file, it would perform a full page reload instead... This is never what a user expects, so I've fixed it.


FIXED default ghostMode.location: true 1a0505c

A recent change stopped a module being loaded on the client-side that handled UI events such as 'SYNC ALL' etc.

Issue: #1363


FIXED Added pointer-events: none to notification BrowserSync/browser-sync-client#36


FIXED Page blinking on styles reload is fixed BrowserSync/browser-sync-client#39


The new version differs by 135 commits .

There are 135 commits in total. See the full diff.

@jonicious jonicious closed this Mar 29, 2020
@jonicious jonicious deleted the greenkeeper-browser-sync-2.18.11 branch March 29, 2020 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants