Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client doesn't react to SYNC/RESET ALL buttons unless ghostMode.location = true #1363

Closed
2 of 10 tasks
episode17 opened this issue Apr 22, 2017 · 1 comment
Closed
2 of 10 tasks

Comments

@episode17
Copy link

episode17 commented Apr 22, 2017

Issue details

Using the RESET ALL & SYNC ALL buttons in the ui don't do anything unless

ghostMode: { location: true }

is set. (this option does not seem documented)

Steps to reproduce/test case

  1. Start browser-sync using API
  2. Navigate around in new window
  3. Click RESET ALL in ui
  4. Nothing happens (although the socket receives the event)
  5. add location: true to ghostMode config
  6. Repeat 1 to 3
  7. It works!

Please specify which version of Browsersync, node and npm you're running

  • Browsersync [2.18.8]
  • Node [7.8.0]
  • Npm [4.2.0]

Affected platforms

  • linux
  • windows
  • OS X
  • freebsd
  • solaris
  • other (please specify which)

Browsersync use-case

  • API
  • Gulp
  • Grunt
  • CLI
const browserSync = require('browser-sync').create();

browserSync.init({
    proxy: {
        target: 'localhost:9091',
        ws: true
    },
    ghostMode: {
        location: true // Fix
    }
});
@shakyShane
Copy link
Contributor

@episode17 great catch! fix incoming

This was referenced May 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants