Added static code analysis / PMD #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jongpie
added
the
devops
jongpie
added this to the Version 4.7.0: More Data + Data Security Enhancments milestone
Codecov Report
@@ Coverage Diff @@
## feature/security-enhancements #201 +/- ##
==============================================================
Coverage 95.20% 95.20%
==============================================================
Files 26 26
Lines 2689 2689
Branches 25 25
==============================================================
Hits 2560 2560
Misses 129 129
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
jongpie
reviewed
Sep 13, 2021
nebula-logger/tests/logger-engine/classes/LogEntryEventBuilder_Tests.cls
Outdated
Show resolved
Hide resolved
jongpie
reviewed
Sep 13, 2021
nebula-logger/tests/log-management/classes/LogMassDeleteExtension_Tests.cls
Show resolved
Hide resolved
jongpie
approved these changes
Sep 13, 2021
Merged
jongpie
added a commit
that referenced
this pull request
Sep 14, 2021
* Added StripInaccessibleRecordFields__c setting * Added all CMDT objects to LoggerAdmin.permissionset * Added LogEntryDataMaskRule__mdt object for applying data mask rules to log entry message & record JSON fields in LogEntryEventBuilder * Added CMDT rules for credit card numbers & social security numbers * Added setting ApplyDataMaskRules__c to control if CMDT data mask rules are applied * Added some user managament settings to scratch-def files * Added test suites for each module * Moved some test helper methods to LoggerTestUtils, cleaned up LogEntryEventBuilder_Tests methods * Optimized setTagsDetails() * Made record & records parameters optional in FlowRecordLogEntry & FlowCollectionLogEntry (respectively) to handle situations where null is passed (e.g., Get Records returns null for no matches, instead of an empty list) (reported in #198) * Changed FlowDescription__c.field to long text area + added automatic field-truncation for LogEntry__c inserts + added a ridiculously long description to one of the Flows in nebula-logger-recipes (reported in #199) * Made fancier buttons that include the release number * Cleaned up a few areas in README * Added 'Code Quality Tests' to deploy.yml + ran prettier * Setup ESLint for lwc + fixed some reported issues * Removed some unused scripts in package.json * Switched back to using extra-tests folder, created LogEntryEventBuilder_IntegrationTests class (AccountBrand doesn't exist in all orgs) * Added new step to pipeline to create an unvalidated package version & auto-install it into the package-demo org, then reinstall the latest released package version * Reenabled Codecov.io integration in the pipeline * Added static code analysis / PMD through sfdx-scanner (#201 by @jamessimone) * Fixed line breaks not working when calling System.debug() @jamessimone and I had a lot of... "fun" with this one Co-authored-by: James Simone <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sfdx-scanner