-
-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Security enhancements #188
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o log entry messages
… the masked text to help further obfuscate data Handled via new field MaskedTextLength__c on LogEntryDataMaskRule__mdt
jongpie
added
Type: Enhancement
New feature or request
Package Type: Managed Package
Issues and enhancements that specifically apply to the managed package
Layer: Configuration
Items related to the custom hierarchy setting LoggerSettings__c or any included custom metadata type
Layer: Log Management
Items related to the custom objects & Logger Console app
Package Type: Unlocked Package
Issues and enhancements that specifically apply to the unlocked package
Salesforce Feature: Platform Events
Items related to how platform events are leveraged by Nebula Logger
Salesforce Feature: Security
Items related to the security model (object-level access, field-level security, record sharing)
labels
Aug 26, 2021
jongpie
force-pushed
the
feature/security-enhancements
branch
from
August 26, 2021 06:04
cbd6958
to
0cadbf6
Compare
jongpie
force-pushed
the
feature/security-enhancements
branch
from
September 13, 2021 05:42
3d1951d
to
cc0c556
Compare
… auto-install it into the package-demo org, then reinstall the latest released package version
jongpie
force-pushed
the
feature/security-enhancements
branch
from
September 13, 2021 05:49
cc0c556
to
07d82af
Compare
jongpie
added
the
devops
Items related to tooling, automation, and guidelines used for developing Nebula Logger
label
Sep 13, 2021
@jamessimone and I had a lot of... "fun" with this one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
devops
Items related to tooling, automation, and guidelines used for developing Nebula Logger
Layer: Configuration
Items related to the custom hierarchy setting LoggerSettings__c or any included custom metadata type
Layer: Log Management
Items related to the custom objects & Logger Console app
Layer: Logger Engine
Items related to the core logging engine
Salesforce Feature: Platform Events
Items related to how platform events are leveraged by Nebula Logger
Salesforce Feature: Security
Items related to the security model (object-level access, field-level security, record sharing)
Type: Enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR covers a few items that don't have issues logged, but handle a few security-related enhancements I've been considering for a few months (years??)
🥉 3rd place:
LoggerAdmin
permission set now has access to all custom metadata types included in the repo. Is this a bugfix, or is this an enhancement? Who can say?! But all CMDT objects are now included.🥈 2nd place: new setting
LoggerSettings__c.StripInaccessibleRecordFields__c
- Disabled by default, when enabled, any time anSObject
record is logged (or aList<SObject>
is logged), only fields that the current user can access will be included in the record's JSON. This is useful in orgs where end-users have access to viewLog__c
andLogEntry__c
records.🥇 1st place: data masking for log entry messages. Enabled by default, regex-based CMDT rules can be configured to automatically mask sensitive data in the
Message__c
andRecordJson__c
fields. Pre-built rules are included for credit card numbers and social security numbers - additional rules can be configured by creating additionalLogEntryDataMaskRule__mdt
records.New
LoggerSettings__c
fields:ApplyDataMaskRules__c
andStripInaccessibleRecordFields__c
New custom metadata type
LogEntryDataMaskRule__mdt
list view, showing the included rulesExample log entries with masked data - the 1st two entries shows masked credit card numbers, and the 3rd entry shows a masked social security number
Other included changes:
LogEntryEventBuilder
that involve queries - this prevents the queries from executing if logging is disabled for the current usersetTransactionDetails()
inLogEntryEventBuilder
to defer setting some transactional details until absolutely necessary - this helps minimize heap size/avoid using some of the heap size limit until neededapex-scanner
plugin + fixed some reported issues (via PR Added static code analysis / PMD #201)