Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SearchList from Matchless #1300

Merged
merged 4 commits into from
Dec 9, 2024
Merged

Conversation

johnynek
Copy link
Owner

@johnynek johnynek commented Dec 7, 2024

with #1299 we don't need to have separate searchList code in each backend, just use WhileExpr.

Copy link

codecov bot commented Dec 7, 2024

Codecov Report

Attention: Patch coverage is 76.00000% with 18 lines in your changes missing coverage. Please review.

Project coverage is 89.52%. Comparing base (04a0e87) to head (45c7c0f).
Report is 110 commits behind head on main.

Files with missing lines Patch % Lines
...re/src/main/scala/org/bykn/bosatsu/Matchless.scala 68.96% 9 Missing ⚠️
...cala/org/bykn/bosatsu/codegen/clang/ClangGen.scala 70.00% 6 Missing ⚠️
...main/scala/org/bykn/bosatsu/MatchlessToValue.scala 80.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1300      +/-   ##
==========================================
- Coverage   91.32%   89.52%   -1.81%     
==========================================
  Files          96      106      +10     
  Lines       11846    13302    +1456     
  Branches     2675     3055     +380     
==========================================
+ Hits        10818    11908    +1090     
- Misses       1028     1394     +366     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johnynek johnynek merged commit 189c5b0 into main Dec 9, 2024
8 checks passed
@johnynek johnynek deleted the oscar/20241207-remove_seach_list branch December 9, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant