Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add while to matchless #1299

Merged
merged 6 commits into from
Dec 7, 2024
Merged

add while to matchless #1299

merged 6 commits into from
Dec 7, 2024

Conversation

johnynek
Copy link
Owner

@johnynek johnynek commented Dec 7, 2024

this closes #770 by moving a lot of the logic of while construction into a single place, then generate while loops after. This unifies 3 implementations (MatchlessToValue, python, c).

It also opens the door to possibly remove the SearchList node since I think that can be rewritten as a while loop.

Copy link

codecov bot commented Dec 7, 2024

Codecov Report

Attention: Patch coverage is 94.64286% with 9 lines in your changes missing coverage. Please review.

Project coverage is 89.34%. Comparing base (04a0e87) to head (0db54bc).
Report is 110 commits behind head on main.

Files with missing lines Patch % Lines
...main/scala/org/bykn/bosatsu/MatchlessToValue.scala 89.58% 5 Missing ⚠️
...re/src/main/scala/org/bykn/bosatsu/Matchless.scala 95.83% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1299      +/-   ##
==========================================
- Coverage   91.32%   89.34%   -1.98%     
==========================================
  Files          96      106      +10     
  Lines       11846    13335    +1489     
  Branches     2675     3054     +379     
==========================================
+ Hits        10818    11914    +1096     
- Misses       1028     1421     +393     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johnynek johnynek merged commit 2c08a6b into main Dec 7, 2024
10 checks passed
@johnynek johnynek deleted the oscar/20241207-add_while_matchless branch December 7, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

change matchless LoopFn node
1 participant