Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to portable package #2

Closed
wants to merge 3 commits into from

Conversation

FranklinYu
Copy link

@FranklinYu FranklinYu commented Nov 28, 2018

Closes #1.

It is expected that user having v11.0.0 or v11.0.1 installed would upgrade to this version without issue. I have tested only in one machine.

Upgrade from v11.0.1:

choco install openjdk
choco upgrade --debug --verbose --source=. openjdk

From v11.0.0:

choco install openjdk --version 11.0
choco upgrade --debug --verbose --source=. openjdk

Implementation note: the polyfilled function will be implemented in chocolatey/choco#1663.

The API has not been settled; Having custom name is future-proof.
@johanjanssen
Copy link
Owner

Thanks a lot for the commits @FranklinYu!

I've been looking into portable packages a bit more. From what I've read portable packages have some advantages and 'normal' install packages have some other advantages.

So my idea would be to keep the current openjdk install package as is. Then I'll create another package for the portable one. So then the portable one can be installed with choco install openjdk.portable. That way users can pick whatever installation option they want.

What do you think about that? I could probably do that this week or next week.

@FranklinYu
Copy link
Author

'normal' install packages have some other advantages.

?

@johanjanssen
Copy link
Owner

For instance being more visible installed in a more common directory instead of hidden somewhere within a Chocolatey directory. I'm more then happy to create a portable package, but I also don't want to upset people who already use the current package. So I'd rather stick to the current package and create a second portable package next to it.

@FranklinYu
Copy link
Author

@FranklinYu FranklinYu closed this Dec 9, 2018
@FranklinYu FranklinYu deleted the feat/portable-jdk branch December 9, 2018 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants