Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(#310) Adds Uninstall-ChocolateyPath and now respects semicolons in paths #1663

Closed
wants to merge 2 commits into from
Closed

(#310) Adds Uninstall-ChocolateyPath and now respects semicolons in paths #1663

wants to merge 2 commits into from

Conversation

jnm2
Copy link

@jnm2 jnm2 commented Oct 17, 2018 •
edited
Loading

@jnm2 jnm2 mentioned this pull request Oct 17, 2018
Closed
@FranklinYu
Copy link
Contributor

I think this should also close #1019?

@jnm2
Copy link
Author

jnm2 commented Oct 17, 2018

1019 is a PR. Does it make sense to autoclose one PR from another?

@FranklinYu
Copy link
Contributor

Makes sense to me, because this PR supersedes #1019.

@mjscosta mjscosta mentioned this pull request Nov 8, 2018
Open
@FranklinYu FranklinYu mentioned this pull request Nov 28, 2018
Closed
@jnm2
Copy link
Author

jnm2 commented Feb 6, 2019

@gep13 Is there anything I can do to help get this merged?

@jnm2 jnm2 mentioned this pull request Nov 1, 2019
Closed
@pauby pauby requested a review from ferventcoder May 25, 2020 10:49
@CLAassistant
Copy link

CLAassistant commented Jun 8, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@gep13 gep13 mentioned this pull request Sep 10, 2020
Closed
@jmcker jmcker mentioned this pull request Jun 16, 2021
Closed
@jtcmedia
Copy link

Is this going to get merged? It would be extremely useful.

@pauby pauby requested review from gep13 and removed request for ferventcoder July 23, 2021 11:16
jmcker added a commit to jmcker/ChocolateyPackages that referenced this pull request Jul 26, 2021
@jmcker
Release gstreamer 1.18.4.20210725
967b1df 
This includes a modified version of the Uninstall-ChocolateyPath script from chocolatey/choco#1663
@gep13 gep13 changed the title (GH-310) Adds Uninstall-ChocolateyPath and now respects semicolons in paths (#310) Adds Uninstall-ChocolateyPath and now respects semicolons in paths Oct 14, 2021
@jnm2 @jmcker
Apply suggestions from @jmcker
dc44ca8 
Co-authored-by: Jack McKernan <[email protected]>
@jnm2
Copy link
Author

jnm2 commented Oct 2, 2022

Since we're nearing the start of the fifth year that this will be open, I may close this due to lack of attention.

@jmooring
Copy link

@gep13 Can you or someone else on your team have a look at this, please.

@pauby
Copy link
Member

pauby commented Nov 27, 2022 •
edited
Loading

Please don't ping people on PR's. We are aware of all the PR's and will look at them when we are able to.

@dazeeeed
Copy link

Amazing that this PR is still not merged in 2023, this is such a great feature.

@vexx32
Copy link
Member

vexx32 commented Apr 19, 2024

Apologies for the long wait on this PR. This work is being incorporated into a larger scope of work involving some rewrites that will be submitted soon, so for now we'll close this PR.

Thank you very much for the contribution, this was a really good place to start! 💜

@vexx32 vexx32 closed this Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmcker jmcker jmcker requested changes

@gep13 gep13 Awaiting requested review from gep13

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Uninstall-ChocolateyPath function to manage removing entries from PATH
9 participants
@jnm2 @FranklinYu @CLAassistant @jtcmedia @jmooring @pauby @dazeeeed @vexx32 @jmcker