add support for z/OS #520
Closed
add support for z/OS #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to workaround previous (to v14) versions of node and a compiler bug affected by those versions, as follows: - v8 (ships with D190508), requires -U_VARARG_EXT_ and no-opt - v12 (ships with D191122), requires no-opt - v14 (ships with D191122), no workaround needed.
Find Java's lib_dir to link to libjvm.x, instead of assuming users have their LDFLAGS env variable set to that path.
zos: rebase and apply custom compile flags to support Node v8, v12 and v14
The destructor InstanceMethodCallBaton() calls m_javaObject->Unref() which aborts when m_javaObject is NULL. Affects at least `npm test` from `node-jdbc` npm, which aborts in test `testcreatetable`: (abort) [0x26C7C640] (__cxa_end_catch) [0x2E2CC414] (InstanceMethodCallBaton::~InstanceMethodCallBaton()+0x140) [0x2E2CD2A4] (Nan::AsyncWorker::Destroy()@AF61_58+0x28) [0x2E2CCE4C] (Nan::AsyncWorker::Destroy()+0x18) [0x2E2C9F12] (Nan::AsyncExecuteComplete(uv_work_s*)+0x4e) [0x27DB5430] ...
src: verify pointer before calling its method
|
merged manually because of merge conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include the following changes specific to z/OS:
and: