zos: rebase and apply custom compile flags to support Node v12 and v14 #1
Conversation
Bumps [handlebars](https://github.com/wycats/handlebars.js) from 4.1.2 to 4.5.3. - [Release notes](https://github.com/wycats/handlebars.js/releases) - [Changelog](https://github.com/wycats/handlebars.js/blob/master/release-notes.md) - [Commits](handlebars-lang/handlebars.js@v4.1.2...v4.5.3) Signed-off-by: dependabot[bot] <[email protected]>
…ter_work callback for uv_queue_work(), since uv_queue_work() is not supposed to be called outside of main thread. Fixes queue corruption problem when multiple simultaneous proxy calls come in from separate threads.
This is to workaround previous (to v14) versions of node and a compiler bug affected by those versions, as follows: - v8 (ships with D190508), requires -U_VARARG_EXT_ and no-opt - v12 (ships with D191122), requires no-opt - v14 (ships with D191122), no workaround needed.
gabylb
changed the title
This is to enable node-jdbc to use the latest, unmerged update that resolves dependant node-java build failure with Node v14. That update is ibmruntimes/node-java#1 and is pending approval/merge.
There was a problem hiding this comment.
Hi @gabylb, there seems to be other commits from upstream in this PR, so I only reviewed on the ones you commited. Your changes look goods to me, but I'm wondering if you also need to add a special case for zOS to include the additional library options -- i.e. similar to the ones documented here: https://www.ibm.com/support/knowledgecenter/en/SSYKE2_8.0.0/com.ibm.java.vm.80.doc/docs/jni_runtime_linking.html#jni_libs_zos
Find Java's lib_dir to link to libjvm.x, instead of assuming users have their LDFLAGS env variable set to that path.
|
Thanks Joran @joransiu for your useful feedback. Please see new commit. btw on z/OS Java there's no libjvm.a, so -ljvm on that URL won't work, and also there's no jre under <java_install_dir>. I checked this on tlba98me (v2r2), zoscan2b (v2r3), torolabd (v2r4-pre). |
This PR updates package.json to get a node-java version that resolves the subject issue in new branch node14-zos: https://github.com/ibmruntimes/node-java.git It also removes the requirement of setting LDFLAGS env var prior to building node-java or node-jdbc. Ref: ibmruntimes/node-java#1
|
Just found that the last commit d6ec935 breaks build of node-java in Node v8, because Node v8 emits its output from Users of Node v8 who want to newly download https://github.com/ibmruntimes/node-jdbc should now get branch |
gabylb
changed the title
This PR merges current latest joeferner@bc557ad with 11d557d and updates binding.gyp to enable node-java to be build with v12 and v14 without explicitly settings compiler flags, as follows:
npm testactually fails with no-opt)The latest version from joeferne is required to resolve v8 API incompatibility issues with v8 (8.1) from Node v14.
It also converts GetContents() to GetBackingStore() for Node versions 8 and up.
The
package.jsonfrom node-jdbc (https://github.com/ibmruntimes/node-jdbc/tree/zos) still needs to be updated to replace dependency:"java": "git+https://github.com/ibmruntimes/node-java.git#node12-zos",
by:
"java": "git+https://github.com/ibmruntimes/node-java.git#node14-zos",