Write to json #350
Merged
Write to json #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into updateAnimationSettingTooltip
👇 Click on the image for a new way to code review
Legend |
jmakhack
reviewed
Oct 14, 2022
src/main/java/com/hydratereminder/command/total/TotalBreakWriter.java
Outdated
Show resolved
Hide resolved
jmakhack
reviewed
Oct 14, 2022
src/main/java/com/hydratereminder/command/total/TotalBreakWriter.java
Outdated
Show resolved
Hide resolved
|
@jmakhack I've made the requested changes. |
jmakhack
approved these changes
Oct 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Associated Issue
Store total hydration breaks for all time in a .json file instead of .log file
Closes #322
Implemented Solution
Used Gson to read/write json from/to a .json file
Testing Details
Tested in game
Operating System: Windows 11
RuneLite Version: 1.9.1
Screenshots