Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track chat command usage in stats json file #356

Open
jmakhack opened this issue Oct 14, 2022 · 6 comments
Open

Track chat command usage in stats json file #356

jmakhack opened this issue Oct 14, 2022 · 6 comments
Labels
enhancement New feature or request hacktoberfest This issue qualifies for the hacktoberfest event help wanted Extra attention is needed java Pull requests that update Java code up for grabs Any issue that is up for grabs
Milestone

Comments

@jmakhack
Copy link
Owner

jmakhack commented Oct 14, 2022

Feature Reasoning

For future potential features, it would be nice to track how many times the player has used every chat command.

Feature Description

This enhancement is to increase a counter in hydrateReminderStats.json whenever any chat command is used. The result json should look like the following:

{
    "commandCounts" : {
        "help": 5,
        "next": 2,
        "prev": 11,
        "reset": 4,
        "total": 8,
        "party": 3,
        "hydrate": 8
    },
    "totalHydrateCount": 0
}

Add unit tests and avoid repeating logic where possible. When new commands are added in the future, this logic should automatically be applied without any extra code.

Possible Alternatives

Any alternatives to the proposed schema may be acceptable.

Additional Context

Note: This work cannot be started until #350 gets merged in first.

Please refer to CONTRIBUTING.md for info on how to setup, build, run, and test this project.

@jmakhack jmakhack added enhancement New feature or request help wanted Extra attention is needed java Pull requests that update Java code hacktoberfest This issue qualifies for the hacktoberfest event up for grabs Any issue that is up for grabs labels Oct 14, 2022
@jmakhack jmakhack added this to the v2.0.0 milestone Oct 14, 2022
@ron-huberfeld
Copy link
Contributor

Hi @jmakhack
Can I have this one?

@jmakhack
Copy link
Owner Author

Go for it @ron-huberfeld :)

@jmakhack
Copy link
Owner Author

jmakhack commented Nov 4, 2022

@ron-huberfeld, just checking in. Are you still planning to work on this?

@ron-huberfeld
Copy link
Contributor

Yes. Is it urgent. I'm a bit busy at the moment but still want to do it.

@jmakhack
Copy link
Owner Author

jmakhack commented Nov 4, 2022

@ron-huberfeld, no worries. Just checking in on all the assigned issues :)

@ron-huberfeld
Copy link
Contributor

Hi @jmakhack is this issue still open and count for hacktoberfest 2023?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest This issue qualifies for the hacktoberfest event help wanted Extra attention is needed java Pull requests that update Java code up for grabs Any issue that is up for grabs
Projects
None yet
Development

No branches or pull requests

2 participants