[Discover] fix: infinite loop for view single document on disc… (elas…

…tic#60236)
jloleysens · Mar 16, 2020 · a0605fd · a0605fd
1 parent 0f97a58
commit a0605fd
Showing 1 changed file with 24 additions and 26 deletions.
diff --git a/src/legacy/core_plugins/kibana/public/discover/np_ready/components/doc/use_es_doc_search.ts b/src/legacy/core_plugins/kibana/public/discover/np_ready/components/doc/use_es_doc_search.ts
@@ -62,36 +62,34 @@ export function useEsDocSearch({
   const [status, setStatus] = useState(ElasticRequestState.Loading);
   const [hit, setHit] = useState<ElasticSearchHit | null>(null);
 
-  async function requestData() {
-    try {
-      const indexPatternEntity = await indexPatternService.get(indexPatternId);
-      setIndexPattern(indexPatternEntity);
+  useEffect(() => {
+    async function requestData() {
+      try {
+        const indexPatternEntity = await indexPatternService.get(indexPatternId);
+        setIndexPattern(indexPatternEntity);
 
-      const { hits } = await esClient.search({
-        index,
-        body: buildSearchBody(id, indexPatternEntity),
-      });
+        const { hits } = await esClient.search({
+          index,
+          body: buildSearchBody(id, indexPatternEntity),
+        });
 
-      if (hits && hits.hits && hits.hits[0]) {
-        setStatus(ElasticRequestState.Found);
-        setHit(hits.hits[0]);
-      } else {
-        setStatus(ElasticRequestState.NotFound);
-      }
-    } catch (err) {
-      if (err.savedObjectId) {
-        setStatus(ElasticRequestState.NotFoundIndexPattern);
-      } else if (err.status === 404) {
-        setStatus(ElasticRequestState.NotFound);
-      } else {
-        setStatus(ElasticRequestState.Error);
+        if (hits && hits.hits && hits.hits[0]) {
+          setStatus(ElasticRequestState.Found);
+          setHit(hits.hits[0]);
+        } else {
+          setStatus(ElasticRequestState.NotFound);
+        }
+      } catch (err) {
+        if (err.savedObjectId) {
+          setStatus(ElasticRequestState.NotFoundIndexPattern);
+        } else if (err.status === 404) {
+          setStatus(ElasticRequestState.NotFound);
+        } else {
+          setStatus(ElasticRequestState.Error);
+        }
       }
     }
-  }
-
-  useEffect(() => {
     requestData();
-  });
-
+  }, [esClient, id, index, indexPatternId, indexPatternService]);
   return [status, hit, indexPattern];
 }