Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] fix: infinite loop for view single document on discover #60236

Merged

Conversation

mbondyra
Copy link
Contributor

@mbondyra mbondyra commented Mar 16, 2020

Fixes infinite loop of requests for view single document in discover tab.

Summary

Fixes #60230

Checklist

Delete any items that are not applicable to this PR.

For maintainers

Release note

Fixes infinite loop of requests for view single document on Discover.

@mbondyra mbondyra added Feature:Discover Discover Application release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.6.1 labels Mar 16, 2020
@mbondyra mbondyra requested review from timroes and lizozom March 16, 2020 10:04
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@mbondyra mbondyra requested a review from lizozom March 16, 2020 10:17
Copy link
Contributor

@lizozom lizozom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it doesn't do the infinite loop anymore, but it does fetch the data twice on the single doc view

@mbondyra
Copy link
Contributor Author

Created an issue for duplicated request: #60242

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mbondyra mbondyra merged commit a0605fd into elastic:7.6 Mar 16, 2020
@mbondyra mbondyra deleted the fix_infinite-loop-view-single-document-discover branch March 16, 2020 11:52
@timroes timroes added v7.6.2 and removed v7.6.1 labels Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Discover Discover Application release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.6.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants