Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with downloading a filtered report #248

Merged

Conversation

luukverhoeven
Copy link
Contributor

  • Resolves the issue where all data is downloaded instead of just the filtered data.

@luukverhoeven
Copy link
Contributor Author

Hi @jleyva, we've identified an issue where all data, instead of just the filtered data, is being downloaded. Could you please review and approve the pull request? Thanks!

@rmartinezgc
Copy link

Good morning. When are you planning to incorporate these changes into the version of the plugin published in moodle? We currently have our moodle away on a server that does not allow custom changes to the source code.

Thank you.

Regards.

@martingskillset
Copy link

Hi @jleyva - I can confirm that the issue 1 fix works - is there any chance this could be rolled up into a new version please?

@jleyva jleyva merged commit 17091f9 into jleyva:MOODLE_401_STABLE Oct 3, 2024
7 checks passed
@jleyva
Copy link
Owner

jleyva commented Oct 3, 2024

We will publish an updated version of the plugin with this fix once Moodle LMS 4.5 is released

@martingskillset
Copy link

Thank you - much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants