Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M4.1 - PHP 8.1 | Bar and Line graph image don't work #2

Closed
gemguardian opened this issue May 9, 2024 · 21 comments
Closed

M4.1 - PHP 8.1 | Bar and Line graph image don't work #2

gemguardian opened this issue May 9, 2024 · 21 comments
Assignees
Labels
wontfix This will not be worked on

Comments

@gemguardian
Copy link
Member

@luukverhoeven could you please check if this is something that is caused by our changes or already was broken ?

If so - and it is not part of the bug support anymore - could you please let me know what the time is to fix this?

You can download the XML file from: https://www.ltncbestanden.nl/s/kPG6E05jTvebTv1f since Github refuses the upload.

image

When I select the urls from the inspect tool I get the following errors
image

image

@luukverhoeven
Copy link
Collaborator

@gemguardian Kun je de link naar de afbeelding delen? Ik krijg geen foutmelding met jouw voorbeeld, mogelijk omdat er niet voldoende data in mijn omgeving aanwezig is.

luukverhoeven added a commit that referenced this issue May 11, 2024
@luukverhoeven
Copy link
Collaborator

@gemguardian Ik kon daar meerdere issues in vinden. Ik weet niet of het eerder goed heeft gewerkt. Kun je testen of de laatste aanpassing in MOODLE41 branch correct werkt?

image

image

@luukverhoeven
Copy link
Collaborator

@gemguardian Kun je de laatste versie testen? Ik vond een mogelijke fout, maar ik kan dit niet goed lokaal testen vanwege te weinig data. Misschien is het ook goed om de instellingen van de plot in deze rapportage te controleren.

image

@gemguardian
Copy link
Member Author

@luukverhoeven ik heb geprobeerd met aangepaste instellingen maar ik krijg het niet zichtbaar. Ik ga het doorzetten naar de melder, wellicht dat het hem lukt om data te tonen want mij lukt het niet. Maar ik werk dus ook nooit mee om te weten wat ik dan fout doe.

@gemguardian
Copy link
Member Author

@luukverhoeven ik heb contact gehad met de melder van het issue. Deze is momenteel met vakantie en zal gaan testen als hij terug is. Dit zal dus de komende 2-3 weken in ieder geval nog stil liggen.

@gemguardian gemguardian added bug Something isn't working Waiting on reply labels May 16, 2024
@gemguardian
Copy link
Member Author

@luukverhoeven I have not received any response from Darrel who pointed it out. As far as I can see this is fixed. I belive you have it in the 4.1 branche. If so we close this comment.

@Jay-lab-1
Copy link

@gemguardian:

Hi,

I have tested version 4.1.0 of the block_configurable_reports plugin in Moodle 4.3 with PHP8.0.30 and PHP8.1.28 and found that none of the three selectable charts (Bar, Line, Pie) now generate images (05.06.24).

I get the following error messages in the web console
Screenshot from 2024-06-05 15-10-00

Since I haven't seen an update in the branch, I wanted to ask if this bug has been fixed yet.

I look forward to your feedback.

Best regards,
Jay

@gemguardian
Copy link
Member Author

@Jay-lab-1

have you tested the branche: https://github.com/Lesterhuis-Training-en-Consultancy/moodle-block_configurable_reports?

You do mention 4.3 - We have not tested it on this version of Moodle.

@Jay-lab-1
Copy link

Thank you for the quick response. We have tested this with the version 4.1.0 of the plugin.

@gemguardian
Copy link
Member Author

gemguardian commented Jul 9, 2024

@Jay-lab-1 can you send me the JSON download of your query /settings so I can test it myself?

I ment the XML

@Jay-lab-1
Copy link

Jay-lab-1 commented Jul 10, 2024

@gemguardian
Unfortunately, I currently only have the option of testing with the following version.
Moodle 4.3.5+ (Build: 20240705)]
PHP 8.2.4

Upload of XML is not possible, therefore i renamed the file to *.txt
Student count.txt

Pie chart and line graph seem to work. but nothing is displayed in the bar chart

@gemguardian
Copy link
Member Author

@Jay-lab-1 thank you - It might be a M4.3 / PHP 8.2 thing, but I will verify it on my end. It will be somewhere next week due to the holidays and planning

@gemguardian
Copy link
Member Author

@Jay-lab-1 I have tested in M4.4 , PHP 8.1 and I have 2 out 3 - see screenshot below.

@luukverhoeven the Line Graph still does not wat to appear for me, as I had in a previouw test. Could you please let me know how much time it would cost you to check this? We focus on PHP8.1

image

When I take the URL from the inspect tool and put into Moodle I get this notification
image

@Jay-lab-1
Copy link

@gemguardian
I tested it again and did not get an error via Moodle debugging, but via the Webdeveloper Console
2024-08-06 08_10_12-Student count _ E-Learning

@gemguardian
Copy link
Member Author

@Jay-lab-1 thank you for sharing the screenshot.

@luukverhoeven see my previous post, could you please take another look why the line graph in PHP8.1 / 4.1 is not working? And let me know how much time it would cost you to check this? We focus on PHP8.1Maybe the information that Jay-lab shared is valuable for this as well.

@luukverhoeven
Copy link
Collaborator

@Jay-lab-1 Thank you for the information.
@gemguardian I will check and validate it. As soon as I have any details or an estimate, I will let you know.

@luukverhoeven
Copy link
Collaborator

@gemguardian I think it will take us 3 hours to investigate, find the issue, and resolve it.

@luukverhoeven luukverhoeven removed their assignment Aug 9, 2024
@gemguardian
Copy link
Member Author

@luukverhoeven thank you for the information. I approve the hours.

@Jay-lab-1 we will focus only on solving this in PHP8.1 and test 4.1

@gemguardian gemguardian added wontfix This will not be worked on and removed bug Something isn't working labels Aug 9, 2024
@gemguardian
Copy link
Member Author

@luukverhoeven I just did a deep dive in this issue - and it's not been caused by the update - as in it is not a regression.
This is a known issue in configurable reports see: jleyva#101

That means I am marking this 'won't fix' - if anyone wants to sponsor solving this issue please contact [email protected]

@gemguardian gemguardian closed this as not planned Won't fix, can't repro, duplicate, stale Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

4 participants