Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New SASL/SCRAM support #67

Merged
merged 1 commit into from
Jan 18, 2021
Merged

New SASL/SCRAM support #67

merged 1 commit into from
Jan 18, 2021

Conversation

fbricon
Copy link
Collaborator

@fbricon fbricon commented Jan 6, 2021

Added SASL/SCRAM-256 and SASL/SCRAM-512 authentication mechanisms:

Screenshot 2021-01-05 at 18 40 26

Tested against a https://www.cloudkarafka.com/ cluster (Free Tier) :

  • connection works (using SCRAM-256)
  • listing brokers, topics, consumer group works
  • producing messages works

Screenshot 2021-01-05 at 18 39 47

There are some things that still don't work against the karafka clusters:

  • creating a topic fails (looks like authorization limitation), even when using the user prefix for the topic name
  • adding/starting a consumer fails (complains about SASL mechanism not supported) fixed

Fixes #3

@fbricon
Copy link
Collaborator Author

fbricon commented Jan 12, 2021

The consumer issue was fixed.
AFAICT, everything works as expected.

@fbricon fbricon changed the title Initial SASL/SCRAM support New SASL/SCRAM support Jan 13, 2021
@dentarg
Copy link

dentarg commented Jan 13, 2021

creating a topic fails (looks like authorization limitation), even when using the user prefix for the topic name

Have you tried prefixing consumer group name with the username? CloudKarafka/python-kafka-example@365850e

@fbricon
Copy link
Collaborator Author

fbricon commented Jan 13, 2021

@dentarg on cloudkarafka, topic creation fails, even with the username prefix. But I could reproduce the same behaviour with a simple java client.
Consumer creation works, even without the username prefix

Signed-off-by: Fred Bricon <[email protected]>
@fbricon
Copy link
Collaborator Author

fbricon commented Jan 15, 2021

CloudKarafka said everything works on their instances: https://twitter.com/CloudKarafka/status/1350071031336153089
I think we're good to go.

@angelozerr angelozerr merged commit a0257d0 into jlandersen:master Jan 18, 2021
@angelozerr
Copy link
Collaborator

Works like a charm with my cloudkafka cluster, great job @fbricon !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for SASL/SCRAM
3 participants