Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SASL/SCRAM #3

Closed
winter98 opened this issue Mar 27, 2019 · 9 comments · Fixed by #67
Closed

Add support for SASL/SCRAM #3

winter98 opened this issue Mar 27, 2019 · 9 comments · Fixed by #67
Assignees
Labels
authentication enhancement New feature or request
Milestone

Comments

@winter98
Copy link

Hi,

Do you intend to implement SASL_SSL (particularly SASL_SCRAM) connectivity ?

Thanks.

@jlandersen
Copy link
Owner

Hi

I'd like to support SASL_SSL. The extension is based on https://github.com/SOHU-Co/kafka-node, which currently only supports the PLAIN mechanism. I am a contributor and could look into SCRAM when possible, but for now PLAIN is the more likely one to be supported.
I'll see if I can get it in for next version in the next few weeks.

@jlandersen jlandersen added the enhancement New feature or request label Mar 28, 2019
@jlandersen jlandersen changed the title info request - SASL_SSL Add support for SASL_SSL Mar 28, 2019
@winter98
Copy link
Author

winter98 commented Apr 8, 2019

Would love SASL_SCRAM...

@winter98
Copy link
Author

winter98 commented Apr 8, 2019

But thank you very much

@jlandersen
Copy link
Owner

@winter98 0.7.0 was just pushed which adds SASL/PLAIN. I'll keep this open and track of it and put in SCRAM when it becomes available in dependencies.

@jlandersen jlandersen changed the title Add support for SASL_SSL Add support for SASL/SCRAM Apr 19, 2019
@rsun-thoughtworks
Copy link

Thanks, appreciate it.

@fbricon
Copy link
Collaborator

fbricon commented Nov 23, 2020

SASL/SCRAM should be doable (as well as OAUTHBEARER) once the extension uses kafkajs (see #10) : https://kafka.js.org/docs/configuration#a-name-sasl-a-sasl

@fbricon
Copy link
Collaborator

fbricon commented Jan 5, 2021

@angelozerr if you want to test SASL/SCRAM auth, you can create a free account on https://www.cloudkarafka.com/plans.html

@fbricon
Copy link
Collaborator

fbricon commented Jan 5, 2021

I did a really quick'n dirty test to implement SASL/SCRAM
Screenshot 2021-01-05 at 18 40 26

and it worked (tested against a https://www.cloudkarafka.com/ cluster) :
Screenshot 2021-01-05 at 18 39 47

Unfortunately, I can't seem to be able to produce records on that cloudkarafka topic (Error: Not authorized to access topics: [Topic authorization failed]). I don't know whether it's something I missed in my changes or if it's some sort of cluster limitation)

@fbricon
Copy link
Collaborator

fbricon commented Jan 6, 2021

Anyone interested in seeing SCRAM support, can test PR #67.

Please download the vscode-kafka 0.11.0 build for that PR and follow these instructions to install the vsix file in vscode. Feedback is most welcome!

@angelozerr angelozerr added this to the 0.11.0 milestone Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
authentication enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants