-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add template aliases with node symbol configs #3501
Conversation
b6f062b
to
df8cacf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
df8cacf
to
5ee0e77
Compare
5ee0e77
to
f79f5d0
Compare
f79f5d0
to
9188018
Compare
Is the plan to make it |
I think one-word "log_node"/"op_log_node" labels are more consistent, but "log node"/"op_log node" are also good. |
The advantage of two words is that if you don't need to distinguish between the two you can just specify |
Yes. It's just whether or not we choose consistent naming over convenience.
That makes sense if we stick to the common "node" label. |
What is the best way to use |
Oh, I found it, you said it on Discord:
Update: #3517 |
Documents jj-vcs#3501, though only in `templates.toml` for now (since this is mostly for jj developers to experiment with for now). Let me know if you prefer that I document this in config.md.
Documents jj-vcs#3501, though only in `templates.toml` for now (since this is mostly for jj developers to experiment with for now). Let me know if you prefer that I document this in config.md.
Possible future defaults, for opt-in testing.
Considering we'll keep these in the configs for now I'll use the split setup I use in my own config where labeling and symbols are separate, which grants you some goodies like the working change symbol changing color on a conflicted commit.
Checklist
If applicable:
CHANGELOG.md