Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README refers to deprecated checkout #3209

Closed
joyously opened this issue Mar 4, 2024 · 4 comments · Fixed by #4237
Closed

README refers to deprecated checkout #3209

joyously opened this issue Mar 4, 2024 · 4 comments · Fixed by #4237
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@joyously
Copy link

joyously commented Mar 4, 2024

Description

Although the checkout command was deprecated, the README.md file explains using the "checkout" concept in 3 places.
Also, the screenshot examples use co alias.

Expected Behavior

The README explains in terms of the latest commands.

Actual Behavior

The README explains in old terms.

Specifications

  • Version: 0.14.0
@PhilipMetzger PhilipMetzger added the documentation Improvements or additions to documentation label Mar 4, 2024
@Zambito1
Copy link

Zambito1 commented Mar 5, 2024

The 5th screenshot also refers to merge

@ilyagr
Copy link
Collaborator

ilyagr commented Mar 5, 2024

Fixing this would involve adjusting the scripts in https://github.com/martinvonz/jj/tree/main/demos and then re-running https://github.com/martinvonz/jj/blob/main/demos/run_scripts.sh. I'll hopefully get to it at some point if nobody beats me to it.

@ilyagr
Copy link
Collaborator

ilyagr commented Mar 7, 2024

This is also related to the renewed discussion in #2842

@ilyagr
Copy link
Collaborator

ilyagr commented May 20, 2024

In my mind, this is currently blocked on the decision of whether to turn on #3501 by default.

ilyagr added a commit to ilyagr/jj that referenced this issue Aug 8, 2024
@ilyagr ilyagr mentioned this issue Aug 8, 2024
4 tasks
ilyagr added a commit to ilyagr/jj that referenced this issue Aug 8, 2024
ilyagr added a commit to ilyagr/jj that referenced this issue Aug 8, 2024
ilyagr added a commit to ilyagr/jj that referenced this issue Aug 8, 2024
ilyagr added a commit to ilyagr/jj that referenced this issue Aug 9, 2024
ilyagr added a commit to ilyagr/jj that referenced this issue Sep 5, 2024
ilyagr added a commit to ilyagr/jj that referenced this issue Sep 5, 2024
ilyagr added a commit to ilyagr/jj that referenced this issue Sep 5, 2024
This updates demos to the point where they can run without
warnings. Some of them become less clear, this is addressed
(where I noticed it) in follow-up commits.

Fixes jj-vcs#3209
@ilyagr ilyagr closed this as completed in 1cc1078 Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants