Change stake meta args + format file #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
buffalu
commented
Oct 14, 2022
buffalu
commented
- clion formatted the stake meta arguments
- remove rpc_url and added tip payment program id from Deterministically find tip amounts, add meta to stake info, and cleanup pubkey/strings in MEV tips jito-solana#159
segfaultdoc
previously approved these changes
Oct 14, 2022
esemeniuc
reviewed
Oct 14, 2022
tip-payment/scripts/autoclaim.sh
Outdated
| source ./${DIR}/utils.sh | ||
|
|
||
| RPC_URL=$1 | ||
| HOST_NAME=$2 | ||
|
|
||
| TIP_DISTRIBUTION_PROGRAM_ID=$TIP_DISTRIBUTION_PROGRAM_ID | ||
| TIP_PAYMENT_PROGRAM_ID=$TIP_PAYMENT_PROGRAM_ID |
There was a problem hiding this comment.
curious why do we redefine these variables? are there a scope gotchas?
There was a problem hiding this comment.
that's actually a good question, i was copying without thinking, but at first thought it seems like it should work w/o this
There was a problem hiding this comment.
@segfaultdoc do you know why it's like this?
There was a problem hiding this comment.
nah just for readability
There was a problem hiding this comment.
so you know the vars declared here are the env vars expected by this script
There was a problem hiding this comment.
bash-ing sucks as is, so just tryna make it more digestable
There was a problem hiding this comment.
removed redundant args
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.