Patch to fix Qatari and Latvian flags. #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Identified the problematic data in the rda, changed it. Tests ok with the demo.r file
Also rebuilt the PDF image.
jimjam-slam
reviewed
Aug 24, 2020
| @@ -18,9 +22,12 @@ ggplot(d, aes(x=x, y=y, country=country, size=x)) + | |||
|
|
|||
|  | |||
|
|
|||
There was a problem hiding this comment.
This looks to be like a weird R Markdown rendering glitch, so I might just revert this range if it's all right with you, @RichardMN
|
Thanks very much, @RichardMN! It looks, by the fact that you've regenerated the README and test PDF, that you've been able to test the changes. I might revert the weird line split at the end of README.mdand then merge 😁 Thanks very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to address issues #7 and #14
The RDA has been edited, and a new file which applies this modification to a loaded file (and documents what it is trying to do in comments) has been added. One of the demo files has been adjusted to provide graphs with these two problematic flags.
This now appears to work on my install but I would appreciate someone else having a look at this, and welcome feedback.