-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The flag of Qatar is purple but should be maroon? #14
Comments
The same colour problem appears to affect the flag of Latvia. This is correct upstream in emojione-color https://github.com/eosrei/emojione-color-font/blob/master/assets/emojione-svg/1f1f1-1f1fb.svg but has been oddly transposed here. |
I've had a closer look at the upstream svg. Both the Latvian and Qatari flags appear to have a semi-transparent overlay over the coloured portions of their flags. There are three paths in each SVG, one with a coloured portion (both #c94747), then another with a fractional opacity which adjusts the colour, then a white/grey path. I guess that the SVG/cairo conversion doesn't do the blending well, or the same way other implementations do, and we get weird colours here. I am going to try adjusting the svg and importing and building to see if that fixes this glitch. Latvia
Qatar
|
Thanks very much for taking such a detailed look at this, @RichardMN! I suspect you're right. As you can probably tell, I haven't been able to make big changes to Nevertheless, if we can fix existing problems and allow current users to keep using |
I have done some fiddling and figured out a bit of what may make the problem and I have a fix which works on some of my code but not others. I determined which data in the rda was problematic and how to address it and fix it. This is shown in my branch but I honestly haven't even been able to get this to run in my code running against the rensa master. Another day I will try getting a clean environment and then I think that the following two lines, after loading the ggflags package, should make the necessary change in the data. Suggestions on how to better adjust this would be welcome. I thought I had re-saved the rda but now have something which breaks on loading.
|
See https://en.wikipedia.org/wiki/Flag_of_Qatar
The text was updated successfully, but these errors were encountered: