Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generation Blocked on GitHub and GitLab #233

Closed
SudharakaP opened this issue Sep 10, 2020 · 0 comments · Fixed by jhipster/generator-jhipster#12446
Closed

Generation Blocked on GitHub and GitLab #233

SudharakaP opened this issue Sep 10, 2020 · 0 comments · Fixed by jhipster/generator-jhipster#12446
Labels
Help Needed 🥺 Something that needs help from others Type: Bug 😢 A confirmed bug or something that isn't working as expected

Comments

@SudharakaP
Copy link
Member

We had a issue were generation of applications are blocked on GitHub and GitLab; #184 and #183. These issues seems to be solved when I added the following code snippet;

jhipster-online/src/main/java/io/github/jhipster/online/service/JHipsterService.java

Lines 102 to 106 in 9c6215d

error = new BufferedReader(
new InputStreamReader(p.getErrorStream()));
while ((line = error.readLine()) != null) {
log.debug(line);
}

As per the documentation the process can be blocked if we don't read input and output continuously; https://docs.oracle.com/javase/7/docs/api/java/lang/Process.html

However after migrating to app engine flex, it seems that this issue has resurfaced. 😢

image
@SudharakaP SudharakaP added Type: Bug 😢 A confirmed bug or something that isn't working as expected Help Needed 🥺 Something that needs help from others labels Sep 10, 2020
SudharakaP added a commit to jhipster/generator-jhipster that referenced this issue Sep 14, 2020
@SudharakaP
fix: use then-request instead of sync-request
f69f531 
The library sync-request cannot be used in production applications. Given we use this generator in a production setting in jhipster-online the sync-request will always make the client hang.

Fixes jhipster/jhipster-online#233
@SudharakaP SudharakaP mentioned this issue Sep 14, 2020
Merged
4 tasks
SudharakaP added a commit to jhipster/generator-jhipster that referenced this issue Sep 14, 2020
@SudharakaP
fix: use then-request instead of sync-request
c0f988d 
The library sync-request cannot be used in production applications. Given we use this generator in a production setting in jhipster-online the sync-request will always make the client hang.

Fixes jhipster/jhipster-online#233
SudharakaP added a commit to jhipster/generator-jhipster that referenced this issue Sep 15, 2020
@SudharakaP @mshima
Use then-request Instead of sync-request (#12446)
78605d9 
fix: use then-request instead of sync-request and replace sync request with async request

The library sync-request cannot be used in production applications. Given we use this generator in a production setting in jhipster-online the sync-request will always make the client hang. This also replaces the sync requests with async requests in openapi-client sub-generator.

Fixes jhipster/jhipster-online#233

Co-authored-by: Marcelo Shima <[email protected]>
SudharakaP added a commit to SudharakaP/generator-jhipster that referenced this issue Oct 7, 2020
@SudharakaP
feat: change sync-request library to then-request
9b06d0f 
This is needed as using the sync-request in production can stuck the generation as evidenced in jhipster-online

Duplicates c0f988d, e9fe904, 1e64e9f and f09e68f from the master branch.

Related to jhipster/jhipster-online#233
@SudharakaP SudharakaP mentioned this issue Oct 7, 2020
Merged
5 tasks
SudharakaP added a commit to SudharakaP/generator-jhipster that referenced this issue Oct 7, 2020
@SudharakaP
feat: change sync-request library to then-request
cc5c4b1 
This is needed as using the sync-request in production can stuck the generation as evidenced in jhipster-online

Duplicates c0f988d, e9fe904, 1e64e9f and f09e68f from the master branch.

Related to jhipster/jhipster-online#233
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Help Needed 🥺 Something that needs help from others Type: Bug 😢 A confirmed bug or something that isn't working as expected
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use then-request Instead of sync-request jhipster/generator-jhipster
1 participant
@SudharakaP