Change sync-request library to then-request #12669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SudharakaP
changed the title
This is needed as using the sync-request in production can stuck the generation as evidenced in jhipster-online Duplicates c0f988d, e9fe904, 1e64e9f and f09e68f from the master branch. Related to jhipster/jhipster-online#233
SudharakaP
force-pushed
the
change-sync-request-to-then-request
branch
from
d9c4777 to
cc5c4b1
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed as using the sync-request in production can stuck the generation as evidenced in jhipster-online
Duplicates c0f988d, e9fe904, 1e64e9f and f09e68f from the master branch.
Related to jhipster/jhipster-online#233
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (bellow reviewers) and adding
skip-cilabel, you can still see CI build result at your branch.