WIP: Fix automatic upgrade #5966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested on:
|
TranQuangTienSA
changed the title
|
That issue is the biggest one we had in the recent months, and nobody could fix yet (including me!). If you solved this, many people will thank you!!! |
|
@tientq have a look at https://travis-ci.org/jhipster/generator-jhipster/jobs/245617623 you have some lint issues |
|
Yes, thank for your remind. |
jdubois
approved these changes
Jun 23, 2017
| @@ -32,6 +32,7 @@ util.inherits(UpgradeGenerator, BaseGenerator); | |||
| const GENERATOR_JHIPSTER = 'generator-jhipster'; | |||
| const UPGRADE_BRANCH = 'jhipster_upgrade'; | |||
| const GIT_VERSION_NOT_ALLOW_MERGE_UNRELATED_HISTORIES = '2.9.0'; | |||
| const GENERATOR_JHIPSTER_CLI_VERSION = '4.5.1'; | |||
There was a problem hiding this comment.
this is the current JHipster version, it's already in package.json and should be available (I'll have a look)
There was a problem hiding this comment.
Oh sorry, I didn't understood correctly, this is good
|
I just tried it:
So I'm merging this: whatever problems we might encounter, it's still much better than the current code. THANK YOU SO MUCH @tientq !!!!!!!! |
|
You are welcome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5883
Please make sure the below checklist is followed for Pull Requests.
Travis tests are green
Tests are added where necessary
Coding Rules & Commit Guidelines as per our CONTRIBUTING.md document are followed