-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"jhipster upgrade" not working properly #5883
Comments
Agree 100% with you. But I would really hate to remove this but then if we cannot maintain it we dont have a choice. Since we now have a CLI we have more freedom now so if someone is interested to fix this or find a simpler solution that would be great. Ofcourse there are many ways in which we can make it work but we just dont have the time to spend on it |
Me personally has never used the sub generator (maybe because of my development setup). I always do the update manually, so removing it would be totally ok for me. |
I've used this sub generator quite a bit and it's made it easy for me to easily maintain tutorials over several months, rather than having to re-write them for the latest release. I haven't experienced an issue where the JHipster version can't be upgraded. Does that only happen on particular operating systems? I haven't seen it on macOS Sierra. |
Another (related) issue comes from the CLI:
|
I'm able to confirm that this sub generator did NOT work for me when trying to upgrade from 4.5.2 to 4.5.3. |
The upgrade sub-generator helped me a lot aligning to the latest jhipter. I stuck at JHipster 4.5.1 on my Windows and Linux machine for more than one week, and following the clues @jdubois provided, I can reproduce the issue as:
Then I tried to downgrade the global jhipster:
To prevent the global jhipster dominate the local code generation, I found a workaround:
|
I just tried the steps you outlined in 3: remove generator-jhipster from yarn global install, It seemed to work, but in the end, the only change made on my
|
@mraible Would you please start over again with And you can check the content of package.json at commit "Generated with JHipster 4.5.2" and "Generated with JHipster 4.5.3". |
@tan9 I tried using |
Yep, just confirmed that |
On my side, I tried 4.5.2 to 4.5.3 and failed. With
Which seems to be
No one is having this? |
I'd suggest trying to delete your local
|
Am I now supposed to get it forever to simplify merge? |
But, indeed, deleting the branch worked |
May be we should add in a step to delete the branch if it exists already
…On Fri, 16 Jun 2017, 6:02 pm Henri Tremblay, ***@***.***> wrote:
But, indeed, deleting the branch worked
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#5883 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABDlF4zLIjPuHz35xZ8l6yy8Ea6q98-Yks5sEqcFgaJpZM4Nxnwo>
.
|
If the branch is indeed not historically needed, yes we should delete it.
|
@mraible , @deepu105 I encountered the same issue as @henri-tremblay , and I overcame the issue by just commit the changed package.json or just reset it. And start over the As the error message said:
What happened actually is the version of |
I tried to commit and relaunch. Didn't work.
In my case it was really the generator-jhipster version that was updated in
`package.json`.
|
@henri-tremblay What does "didn't worked" mean? |
@tan9 Sorry. I don't remember. It is possible that I've ended up with a modified |
I can upgrade my project from 4.5.4 to 4.5.5 by executing: $ export PATH=node_modules/.bin/:$PATH
$ jhipster upgrade --with-entities
$ git commit -a -m "Upgraded JHipster to 4.5.5."
$ jhipster upgrade --with-entities @henri-tremblay Would you please remove the entire |
As I said, removing the branch did work.
|
I created a PR. I fix some issues in I tested upgrade from 4.4.0 and 4.5.2 to 4.5.5. There is an issue, when you add other dependencies to the project. Overview of the issueTest scenario:
Problem: Almost thing work well until Motivation for or Use CaseFix this issue, of course. Reproduce the error
Related issuesPR #5966 Suggest a FixPrompt a warning message and wait until the user resolve the conflict JHipster Version(s)4.5.3 JHipster configurationJHipster configuration, a
|
@jdubois could you please give me some comments on the above issue. |
I have been working on a project for more than a year with jhipster 3.10.0 and I'm ready to go to production. I tried to upgrade to the latest version. And I too found that it did'nt work. Before I tried to upgrade I zipped the directory with the project. I unzipped and now the project wont even build -xxxxxxx@x53s-mint ~/projects/colony $ ./gradlew Error: Node Sass does not yet support your current environment: Linux 64-bit with Unsupported runtime (57) FAILURE: Build failed with an exception.
BUILD FAILEDWhat should I do to save it ? |
@oaj could you follow the issue template and give more information. I would like to help. |
3.10.0 to 4.6.2 is a big big jump... |
@oaj When you zip/unzip files you lose permissions on Linux so that might be the cause of the issue. Try running |
@PierreBesson - You nailed it, now I can build the 3.10.0 again - Thank you very much. Also thanks to @tientq for your willingness to help out. |
@oaj : yes, manually upgrade is better, because the 4.0.0 introduced some breaking changes for you:
See details here: https://jhipster.github.io/2017/02/02/jhipster-release-4.0.0.html |
I did a manual upgrade according to the release notes, without upgrading my entities at first. And I let 'jhipster' overwrite everything. When i ran ./gradlew I got 7 compile errors in the files under /config `amfibia@x53s-mint ~/projects/colony $ ./gradlew
|
Sorry, but i can upgrade my jhipster.... I did this: But when i execute yo jhipster: JHipster update available: 4.14.3 (current: 4.14.0) Run yarn global upgrade generator-jhipster to update. Its making me crazy.... thanks |
Maybe you have installed generator-jhipster globally with both yarn and npm and your path is pointing to wrong one. Uninstall from both and install only with one. Also you did not give any information on your environment so we can't help you. If you are on Windows run |
As we have basically 4 duplicate tickets on the JHipster upgrade sub-generator, I'm closing #5881 #5869 #5811 #5649 in favor of this new "meta ticket".
It's basically all the same issue: on some systems, the upgrade sub-generator cannot update the JHipster version. Typically, this is because it doesn't have the right to do. Then, there are various other issues depending on how it was installed.
This is why this failing for a lot of people, with different error messages depending on their own configuration and how they installed JHipster. And we can't always reproduce as it depends on our own setup.
This was mostly triggered by the use of Yarn: this adds one more installation mechanism, and it depends on how Yarn was installed.
There is also the issue of people upgrading their JHipster version globally, and then the sub-generator gets stuck with that global version.
-> I'm not sure this is true for everyone, so here is how to test this: say you are using JHipster 4.5.1, do a "jhipster upgrade". You will have a commit telling the application was re-generated with JHipster 4.5.1 (in the commit message). Have a look in the commit, if it's in fact generated with JHipster 4.5.2 (you can see it in
package.json
), then you have the issue of a global JHipster installation that you can't modifyThis is so complex, and doing an upgrade isn't such a big deal to do manually, that I'm considering removing this sub-generator (cc @lordlothar99 as you coded this originally).
We just don't have the time to work on this -> would someone be interested in taking this ticket?
The text was updated successfully, but these errors were encountered: