Add support for Java11 in GAE #10216
Conversation
|
I should also add a note here; according to my experience if you try to deploy a jhipster application on a F1 instance in GAE (java11) the memory is somehow not adequate and thus it won't work. If anyone could reproduce this and verify we should probably put a warning in our generator highlighting this. And interestingly if you look at any example out there by the about Spring Boot application deployment in GAE (java 11) they use the F2 environment (for example even in this very simple application https://github.com/GoogleCloudPlatform/java-docs-samples/blob/master/appengine-java11/springboot-helloworld/src/main/appengine/app.yaml) which makes me think that F1 is not adequate for spring boot deployments. 😄 |
|
+1 for using only java 11 ! |
|
Yes, it has been discussed here: https://groups.google.com/forum/#!topic/jhipster-dev/KJ1Z0Gy0568 |
|
I just tested it and it doesn't work for me. Also this is still using old versions of the app-engine plugins for gradle and maven (v1.3.3, it should be using v2.1.0). |
|
@PierreBesson : Sorry about that, I've missed the app-engine plugins. Although it's interesting since for me it worked. Let me do some more tests in the evening to fix this. 😈 |
|
@PierreBesson : Could you please give some more info on what didn't work for you exactly? I am doing some tests locally and I think I have do some more testing after deleting the app-engine plugins installed in my machine, so that all paths are covered. 😃 |
|
@PierreBesson : I've tested this several times, but couldn't figure out what doesn't work yet; for me it works it seems. Would you be able to provide some more info on what failed for you? |
|
Due to some problems on my side I had to recreate this PR; please refer to the new PR; #10284 |
* Explicitly use Java11 in travis deployment * Convert the existing appengine-web.xml.ejs to app.yaml.ejs for gae java11 support * Remove unnecessary logging file as per; https://cloud.google.com/appengine/docs/standard/java11/java-differences#logging * Modify gradle bootWar task to exclude appengine-web.xml file * Remove web.xml as java11 in gae runs as a jar file not on jetty * Fix issues with the GAE generator (Java 8) Fix #9605 * Add support to give the user a choice in choosing Cloud SQL #10196 * Change the app engine values to reflect the second generation runtimes; https://cloud.google.com/appengine/docs/standard/#instance_classes #10196 * Fix minor bug where I didn't record whether Cloud SQL instance is needed #10196 * Fix minor bug where I didn't record whether Cloud SQL instance is needed #10196 * Fix some bugs and add support for choosing Cloud SQL #10196 * Revert the change to install openjdk through install-jdk scripts as per review * Update google cloud plugins #10216 * Update google cloud plugins; mistake with versions #10216 * changes related to the code review
This migrates our existing GAE generator from Java 8 to Java 11. Note that this will remove all support for Java 8 GAE config file generation (in other words after this fix is merged users will only be able to generate Java 11 GAE configs). I thought this is the best since giving users the ability to choose between Java 8 and Java 11 seems messy since we have migrated other parts of jhipster-generator (such as the travis build to java 11) completely. Also the configs and the way GAE deployments work is very different from Java 8 to Java 11; and Java 11 uses JAR deployment which simplifies matters a lot.
Fix #10196
Please make sure the below checklist is followed for Pull Requests.
Travis tests are green
Tests are added where necessary
Documentation is added/updated where necessary
Coding Rules & Commit Guidelines as per our CONTRIBUTING.md document are followed