-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Travis pipeline to OpenJDK11 #10175
Conversation
I've removed the jdk option of travis; this I believe is useless since it's only used when used in conjunction with language: java. Also I've changed the linux distro to bionic since the default distro used by travis seems to be trusty and that doesn't have openjdk11 preinstalled (bionic does). This I believe makes the travis pipeline cleaner so that we don't have to manually install stuff on it and also could get rid of the jdk_switcher use oraclejdk8 part (which seems redundant anyways).
One of the things that came across my mind (through experience of my own) is that the migration of Travis to OpenJDK11 might impact the way the Google App Engine generator is handled currently. As far as I know in the standard mode of the app engine java11 is in beta and the deployment descriptor should be app.yaml rather than the current appengine-web.xml which will not work probably. I'll comment on this more when I do some more testing (we run a jhipster project on appengine so I'd have a better idea when trying to deploy it there), but if someone could chip in on this that would be wonderful 😄 |
Thanks @SudharakaP About the GAE, we have this ticket #9605 |
I just tried to make it work with V6.2.0 and it is giving me the same error (even if I do the gcloud components install app-engine-java before) D:\JHipster\testgae>gcloud components install app-engine-java All components are up to date. D:\JHipster\testgae>jhipster gae Installing App Engine Java SDK Error: spawn gcloud ENOENT No progress, sorry. |
@pascalgrimaud : I see, would you guys like me to give it a try to migrate the GAE deployment to Java 11 as well? That ticket seems to be worked by some people, so I don't know if progress has been made on that front. But by the looks of it the ticket seems to only address bugs in the current GAE generator which supports Java 8 only. I could try to write a new GAE generator for Java 11 with GAE standard. What I have in mind is to give users the option to choose between java 8 and 11 and then based on that generate the deployment files (app.yaml in the case of java 11 and keep the existing java 8 deployment files as it is). |
@SudharakaP : several points :
|
@pascalgrimaud : Thanks for the suggestions. I've created a separate issue to discuss this (#10196). |
@pascalgrimaud : As per our discussion at #10216 (comment); I've changed this. Let me know if there's any issues 😄 |
I've removed the jdk option of travis; this I believe is useless since it's only used when used in conjunction with
language: java
.Also I've changed the linux distro to bionic since the default distro used by travis seems to be trusty and that doesn't have openjdk11 preinstalled (bionic does). This I believe makes the travis pipeline cleaner so that we don't have to manually install stuff on it and also could get rid of the
jdk_switcher use oraclejdk8
part (which seems redundant anyways).Please make sure the below checklist is followed for Pull Requests.
Travis tests are green
Tests are added where necessary
Documentation is added/updated where necessary
Coding Rules & Commit Guidelines as per our CONTRIBUTING.md document are followed