Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keep matching exception to found errorpage #9090

Merged
merged 2 commits into from
Jan 28, 2023

Conversation

olamy
Copy link
Member

@olamy olamy commented Dec 26, 2022

fix TCK test com.sun.ts.tests.servlet.spec.errorpage1.URLClient#servletExceptionTest

@olamy olamy added the TCK For various Specification Test Compatibility Kits (eg: Servlet, WebSocket, HTTP/2, etc) label Dec 26, 2022
@olamy olamy changed the base branch from jetty-10.0.x to jetty-12.0.x December 26, 2022 06:03
@olamy olamy force-pushed the jetty-12.0.x-exception-unwrap-matching-errorpage branch 2 times, most recently from 55ca383 to d8ba0d9 Compare December 27, 2022 05:04
@joakime joakime added this to the 12.0.x milestone Jan 2, 2023
Copy link
Contributor

@gregw gregw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than a name niggle OK

* @return the first non {@link ServletException} from root cause chain
*/
private Throwable getFirstNonServletException(Throwable t)
private Throwable getFirstNonServletException(Throwable t, Class<?> matchedThrowable)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This name is not correct now. How about:

Suggested change
private Throwable getFirstNonServletException(Throwable t, Class<?> matchedThrowable)
private Throwable unwrapServletException(Throwable t, Class<?> matchedThrowable)
Suggested change
private Throwable getFirstNonServletException(Throwable t, Class<?> matchedThrowable)
private Throwable getFirstNonServletException(Throwable t, Class<?> matchedThrowable)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea!
done in 3643858

@olamy olamy force-pushed the jetty-12.0.x-exception-unwrap-matching-errorpage branch from d8ba0d9 to 3643858 Compare January 27, 2023 08:02
@olamy olamy merged commit b0e5074 into jetty-12.0.x Jan 28, 2023
@olamy olamy deleted the jetty-12.0.x-exception-unwrap-matching-errorpage branch January 28, 2023 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment