-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jetty 12 : Handler.Collection
does not propagate Server
to handlers in expected way
#8442
Labels
Bug
For general bugs on Jetty side
Comments
joakime
changed the title
Jetty 12 : Handler.Collection does not propagate Server to handlers
Jetty 12 : Aug 10, 2022
Handler.Collection
does not propagate Server
to handlers in expected way
gregw
added a commit
that referenced
this issue
Aug 10, 2022
Test setServer propagation protect from inadvertent null setting
fixed by a0d6f42 |
lorban
added a commit
that referenced
this issue
Aug 11, 2022
Signed-off-by: Ludovic Orban <[email protected]>
Closed
@lorban no probs.... any hint to how the build was broken? |
This issue has been automatically marked as stale because it has been a |
github-actions
bot
added
the
Stale
For auto-closed stale issues and pull requests
label
Aug 12, 2023
This was fixed during Handler restructure in 12. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Jetty version(s)
Jetty 12
Description
In Jetty 12, if you use the jetty-core
org.eclipse.jetty.server.Handler$Collection
the.setHandlers(List)
does not propagate theServer
correctly.Example code.
The
DefaultHandler.setServer(Server)
never gets called with a valid Server instance.This is because the internal
Handler.Collection
processing does it'shandler.setServer(server)
far too early.AFAICT, this seems to be the only Handler implementation with this bug.
The text was updated successfully, but these errors were encountered: