Fixes #8858 - Jetty 12 Review MovedContextHandler. #8859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated method names to avod references to Servlet concepts. Added test cases. Updated XML files. Signed-off-by: Simone Bordet <[email protected]>
gregw
approved these changes
Nov 3, 2022
Comment on lines
183
to
185
| String cacheControl = getCacheControl(); | ||
| if (cacheControl != null) | ||
| response.getHeaders().put(HttpHeader.CACHE_CONTROL, cacheControl); |
There was a problem hiding this comment.
If we wanted to optimise, then when the cache control is set, we could construct a PreEncodedHttpField and then put that rather than build a new HttpField on every request.
Signed-off-by: Simone Bordet <[email protected]>
joakime
requested changes
Nov 3, 2022
| boolean _discardQuery; | ||
| boolean _permanent; | ||
| String _expires; | ||
| private int _statusCode = HttpStatus.SEE_OTHER_303; |
There was a problem hiding this comment.
Should document this default value in the javadoc somewhere.
In getStatusCode() perhaps?
Signed-off-by: Simone Bordet <[email protected]>
joakime
approved these changes
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated method names to avoid references to Servlet concepts. Added test cases.
Updated XML files.
Signed-off-by: Simone Bordet [email protected]