Jetty 12 : Descriptor cleanup
#8611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joakime
changed the title
Descriptor needs a Path to functionDescriptor cleanup
+ Sanity check Resource being provided + Descriptor toString changed to include full URI to descriptor so that it can be used consistently in Logging and Exception messages. + New Descriptor.toURI() for use in Servlet Source and other logging messages + Servlet Source value is now the URI of the Descriptor
joakime
force-pushed
the
fix/jetty-12-descriptor-path-constructor
branch
from
64f8c8d to
aa77c88
Compare
.getResource() must be a Resource as it's used in the AnnotationIntrospector all others use new .getName() Not all location/name usages can be loaded as a Resource.
…descriptor-path-constructor
sbordet
requested changes
Sep 27, 2022
jetty-ee10/jetty-ee10-servlet/src/main/java/org/eclipse/jetty/ee10/servlet/Source.java
Outdated
Show resolved
Hide resolved
...e10/jetty-ee10-webapp/src/main/java/org/eclipse/jetty/ee10/webapp/FragmentConfiguration.java
Outdated
Show resolved
Hide resolved
...tty-ee10-webapp/src/main/java/org/eclipse/jetty/ee10/webapp/StandardDescriptorProcessor.java
Outdated
Show resolved
Hide resolved
.../jetty-ee9-plus/src/main/java/org/eclipse/jetty/ee9/plus/webapp/PlusDescriptorProcessor.java
Outdated
Show resolved
Hide resolved
...y-ee9/jetty-ee9-webapp/src/main/java/org/eclipse/jetty/ee9/webapp/FragmentConfiguration.java
Outdated
Show resolved
Hide resolved
...jetty-ee9-webapp/src/main/java/org/eclipse/jetty/ee9/webapp/StandardDescriptorProcessor.java
Outdated
Show resolved
Hide resolved
sbordet
approved these changes
Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taken from PR #8597