Issue #8474 - Jetty 12 - Resource.list() API change + Resource.getFileName() addition
#8582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Introduce Resource.getFileName and use it * Correct signature of Resource.list and use it Signed-off-by: Joakim Erdfelt <[email protected]>
joakime
force-pushed
the
fix/jetty-12-resource-list-sig-change
branch
from
72100c4 to
237f2f4
Compare
joakime
changed the title
Resource.list() API changeResource.list() API change + Resource.getFileName() addition
sbordet
requested changes
Sep 14, 2022
jetty-core/jetty-server/src/main/java/org/eclipse/jetty/server/ResourceListing.java
Outdated
Show resolved
Hide resolved
jetty-core/jetty-server/src/main/java/org/eclipse/jetty/server/ResourceListing.java
Show resolved
Hide resolved
jetty-core/jetty-util/src/main/java/org/eclipse/jetty/util/resource/ResourceCollators.java
Show resolved
Hide resolved
jetty-core/jetty-util/src/main/java/org/eclipse/jetty/util/resource/ResourceCollection.java
Outdated
Show resolved
Hide resolved
jetty-core/jetty-util/src/main/java/org/eclipse/jetty/util/FileID.java
Outdated
Show resolved
Hide resolved
...ee10/jetty-ee10-webapp/src/main/java/org/eclipse/jetty/ee10/webapp/MetaInfConfiguration.java
Outdated
Show resolved
Hide resolved
...ee10/jetty-ee10-webapp/src/main/java/org/eclipse/jetty/ee10/webapp/MetaInfConfiguration.java
Outdated
Show resolved
Hide resolved
jetty-ee10/jetty-ee10-webapp/src/main/java/org/eclipse/jetty/ee10/webapp/WebAppContext.java
Outdated
Show resolved
Hide resolved
jetty-ee9/jetty-ee9-webapp/src/main/java/org/eclipse/jetty/ee9/webapp/MetaInfConfiguration.java
Outdated
Show resolved
Hide resolved
jetty-ee9/jetty-ee9-webapp/src/main/java/org/eclipse/jetty/ee9/webapp/WebAppContext.java
Outdated
Show resolved
Hide resolved
sbordet
approved these changes
Sep 14, 2022
| return r.getURI().toURL(); | ||
| } | ||
|
|
||
| // Resource was returned, but none-existed |
| } | ||
|
|
||
| return resource.getURI().toURL(); | ||
| // Resource was returned, but none-existed |
| } | ||
|
|
||
| return resource.getURI().toURL(); | ||
| // Resource was returned, but none-existed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion around Issue #8474, the API of
Resource.list()has changed.List<String>toList<Resource>New API
Resource.getFileName()has been implemented to make users of the above API easier to implement.When it comes to uniqueness of the entries in the list, that's only relevant for the
ResourceListingclass.All other callers don't need (or want) the uniqueness behaviors.
The uniqueness algorithm in
ResourceListingfor this PR is "first hit".Other algorithms suggested (eg: "most recently updated" / "largest entry" / "last hit" / etc) are not implemented in this PR.