Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #7891 regex pathInfo #7892

Merged
merged 2 commits into from
Apr 25, 2022
Merged

Fix #7891 regex pathInfo #7892

merged 2 commits into from
Apr 25, 2022

Conversation

gregw
Copy link
Contributor

@gregw gregw commented Apr 19, 2022

Use the pathSpec methods to set servletPath and pathInfo when possible. #7891

Signed-off-by: Greg Wilkins [email protected]

Use the pathSpec methods to set servletPath and pathInfo when possible

Signed-off-by: Greg Wilkins <[email protected]>
@gregw gregw requested a review from joakime April 19, 2022 07:27
@gregw gregw added the Sponsored This issue affects a user with a commercial support agreement label Apr 19, 2022
@joakime
Copy link
Contributor

joakime commented Apr 19, 2022

There are test failures on this PR

@gregw gregw changed the title Fix 7891 regex pathInfo Fix #7891 regex pathInfo Apr 19, 2022
@gregw gregw linked an issue Apr 19, 2022 that may be closed by this pull request
Fixed test

Signed-off-by: Greg Wilkins <[email protected]>
@gregw
Copy link
Contributor Author

gregw commented Apr 20, 2022

@joakime passing tests now

@gregw gregw merged commit efd9f26 into jetty-10.0.x Apr 25, 2022
@gregw gregw deleted the jetty-10-7891-regex-pathInfo branch April 25, 2022 06:30
gregw added a commit that referenced this pull request Apr 25, 2022
Fix 7891 regex pathInfo

+ Use the pathSpec methods to set servletPath and pathInfo when possible

Signed-off-by: Greg Wilkins <[email protected]>
@gregw
Copy link
Contributor Author

gregw commented Apr 25, 2022

merged to 11, cherry-picked to 12

joakime pushed a commit that referenced this pull request Oct 6, 2022
Fix 7891 regex pathInfo

+ Use the pathSpec methods to set servletPath and pathInfo when possible

Signed-off-by: Greg Wilkins <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sponsored This issue affects a user with a commercial support agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better Servlet PathMappings for Regex
2 participants