Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#7863 Include value of first accept-encoding header when there is more then one #7864

Conversation

markslater
Copy link
Contributor

Test and fix for first occurrence of accept-encoding header being dropped when more than one accept-encoding header is given.

Signed-off-by: markslater [email protected]

@joakime
Copy link
Contributor

joakime commented Apr 9, 2022

This might be a problem all the way back in jetty-9.4.x too.

@markslater
Copy link
Contributor Author

Yes, the issue has existed since at least 2016, according to git blame.

How does the project's branching strategy work? Should I resubmit my pull request against the jetty-9.4.x branch, or does it get back-ported from the jetty-10.0.x branch?

@joakime
Copy link
Contributor

joakime commented Apr 9, 2022

Our branches ...

  • jetty-9.4.x - in maintenance mode, we'll either do the work there initially and merge up, or cherry pick back into it as needed.
  • jetty-10.0.x - our current stable mainline development, where all new bugs are typically fixed.
  • jetty-11.0.x - we merge from jetty-10.0.x into here, unless there is jetty 11 specific changes needed.
  • jetty-12.0.x - our next development tree (work in progress atm)

Don't worry about 9.4.x (i'll take care of that), but if you can rebase this PR against jetty-10.0.x that would eliminate a few steps for us :-)

…le accept-encoding headers are given.

Signed-off-by: markslater <[email protected]>
@markslater markslater force-pushed the preferred_encoding_order_drops_first_header branch from f17beca to 572eda2 Compare April 10, 2022 16:25
@markslater
Copy link
Contributor Author

Rebased - sorry about that, I must have forgotten to pull before I made the change.

@joakime joakime merged commit 8bcb842 into jetty:jetty-10.0.x Apr 11, 2022
joakime pushed a commit that referenced this pull request Apr 11, 2022
…cept-encoding headers are given. (#7864)

Signed-off-by: markslater <[email protected]>
@joakime joakime added Bug For general bugs on Jetty side merge-12-needed labels Apr 11, 2022
@joakime joakime self-assigned this Apr 11, 2022
@joakime
Copy link
Contributor

joakime commented Apr 11, 2022

Merged into jetty-10.0.x and merged up to jetty-11.0.x.

Cherry-pick to jetty-9.4.x handled in PR #7871

joakime added a commit that referenced this pull request Apr 27, 2022
…cept-encoding headers are given. (#7864) (#7871)

Signed-off-by: markslater <[email protected]>

Co-authored-by: markslater <[email protected]>
joakime pushed a commit that referenced this pull request Oct 6, 2022
…cept-encoding headers are given. (#7864)

Signed-off-by: markslater <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For general bugs on Jetty side
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default servlet drops first accept-encoding header if there is more than one.
2 participants