-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #4919 - WebSocket container graceful stop #4931
Issue #4919 - WebSocket container graceful stop #4931
Conversation
Signed-off-by: Lachlan Roberts <[email protected]>
Signed-off-by: Lachlan Roberts <[email protected]>
Signed-off-by: Lachlan Roberts <[email protected]>
...in/java/org/eclipse/jetty/websocket/javax/server/internal/JavaxWebSocketServerContainer.java
Outdated
Show resolved
Hide resolved
...in/java/org/eclipse/jetty/websocket/javax/server/internal/JavaxWebSocketServerContainer.java
Outdated
Show resolved
Hide resolved
…4919-WebSocketContainerStop Signed-off-by: Lachlan Roberts <[email protected]>
...in/java/org/eclipse/jetty/websocket/javax/server/internal/JavaxWebSocketServerContainer.java
Outdated
Show resolved
Hide resolved
…4919-WebSocketContainerStop
Signed-off-by: Lachlan Roberts <[email protected]>
… is set Signed-off-by: Lachlan Roberts <[email protected]>
...in/java/org/eclipse/jetty/websocket/javax/server/internal/JavaxWebSocketServerContainer.java
Outdated
Show resolved
Hide resolved
...y-server/src/main/java/org/eclipse/jetty/websocket/server/JettyWebSocketServerContainer.java
Outdated
Show resolved
Hide resolved
… interface Signed-off-by: Lachlan Roberts <[email protected]>
@gregw implemented the changes. There is a problem that there is no API for a Javax |
…4919-WebSocketContainerStop Signed-off-by: Lachlan Roberts <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm approving this other than a javadoc and naming niggle and a suggestion to make cancel work a bit better.
I think this PR should be merged, but then we should start another one looking at other improvements in graceful (eg like actually calling cancel if the stopTimeout expires).
jetty-websocket/websocket-util/src/main/java/org/eclipse/jetty/websocket/util/ShutdownUtil.java
Outdated
Show resolved
Hide resolved
jetty-websocket/websocket-util/src/main/java/org/eclipse/jetty/websocket/util/ShutdownUtil.java
Outdated
Show resolved
Hide resolved
...websocket-jetty-client/src/main/java/org/eclipse/jetty/websocket/client/WebSocketClient.java
Outdated
Show resolved
Hide resolved
...websocket-jetty-client/src/main/java/org/eclipse/jetty/websocket/client/WebSocketClient.java
Show resolved
Hide resolved
Signed-off-by: Lachlan Roberts <[email protected]>
…hutdown Signed-off-by: Lachlan Roberts <[email protected]>
@gregw I didn't like the state of this PR so I've done some more changes and now I think it is more in line with the way Now the |
EDIT: Moved to #10918 |
@chylek-qr please open a new issue, a comment on a 3 year old PR is unlikely to be tracked. |
Closes #4919
Make sure all active websocket connections are closed before the connections are hard closed.
Server.doStop()
now initiates a graceful shutdown but only waits for theCompletableFuture
if thestopTimeout
is set.