Issue #5108 - improve scalability of WebSocket SessionTrackers #5109
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #5108
Use a set based on
ConcurrentHashMap
instead ofCopyOnWriteArraySet
for the WebSocket SessionTrackers.The current data structure for
SessionTracker
isCopyOnWriteArraySet
, which has the following description in the javadoc.This seems particularly badly suited to our use case.
getSessions()
very often).doStop()
.