Unrecognized jetty-home/start.jar command line option not reported clearly

[janbartel]

jetty-10.0.x

If I use an unknown command option to start the distro like so:
[941] java -jar ../jetty-home/start.jar --foople

Jetty simply starts. I would expect at least an "unknown option" type warning, maybe even not starting.

[joakime]

In this case, --foople is seen as an unknown command requiring a forked JVM.

It's passed to the forked JVM as a JVM argument.

Seeing as we run on a large variety of JVMs, this is about as good as we can get.

[gregw]

yeah, this is kind of a known problem.... without --exec, we don't start another JVM so you don't get an error from the JVM:

[721] java -jar ../start.jar --exec --foobar
Unrecognized option: --foobar
Error: Could not create the Java Virtual Machine.
Error: A fatal exception has occurred. Program will exit.

[722] java -jar ../start.jar --foobar
WARN  : System properties and/or JVM args set.  Consider using --dry-run or --exec
2020-11-17 16:01:44.545:INFO :oejs.Server:main: jetty-10.0.0-SNAPSHOT; built: 2020-11-17T14:41:00.807Z; git: 3508fdc9559c49792cf1c9a706cb4f5a0a4cc050; jvm 14.0.1+7
2020-11-17 16:01:44.575:INFO :oejdp.ScanningAppProvider:main: Deployment monitor [file:///home/gregw/src/jetty-10.0.x/jetty-home/target/jetty-home/demo/webapps/]
2020-11-17 16:01:44.591:INFO :oejs.AbstractConnector:main: Started ServerConnector@3de26be2{HTTP/1.1, (http/1.1)}{0.0.0.0:8080}
2020-11-17 16:01:44.604:INFO :oejs.Server:main: Started Server@4fb0f2b9{STARTING}[10.0.0-SNAPSHOT,sto=5000] @700ms

I guess we could change this WARN to a fatal error? Shall we? do it now for 10 or wait for 12???

[janbartel]

Well, could the output be at least a little more explicit? I had no idea that the WARN was related to the --foople.

[github-actions]

This issue has been automatically marked as stale because it has been a
full year without activity. It will be closed if no further activity occurs.
Thank you for your contributions.

[github-actions]

This issue has been closed due to it having no activity.

[github-actions]

This issue has been closed due to it having no activity.

[github-actions]

This issue has been closed due to it having no activity.

[joakime]

How about this result?
Seen in PR #7769

$ java start.jar --foople -Dzed.key=0.value
WARN  : System properties and/or JVM args set.  Consider using --dry-run or --exec
WARN  :   Detected JVM System Property: zed.key=0.value
WARN  :   Detected JVM Arg: --foople