chore: remove dependency on realpath-native
#9952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thymikee
reviewed
May 2, 2020
packages/jest-cli/src/init/index.ts
Outdated
|
|
||
| try { | ||
| cwd = fs.realpathSync.native(cwd); | ||
| } catch (error) { |
There was a problem hiding this comment.
can we use tryRealpath instead?
There was a problem hiding this comment.
or create a second helper just for jest-cli, since the other one is in jest-config
thymikee
approved these changes
May 2, 2020
| @@ -29,6 +29,18 @@ import type { | |||
| import shouldInstrument from './shouldInstrument'; | |||
| import handlePotentialSyntaxError from './enhanceUnexpectedTokenMessage'; | |||
|
|
|||
| function tryRealpath(path: Config.Path): Config.Path { | |||
There was a problem hiding this comment.
lots of tryRealPath here and there 😅
|
Yeah... Can stick it in |
|
@SimenB on it |
SimenB
commented
May 2, 2020
CHANGELOG.md
Outdated
| @@ -15,6 +15,7 @@ | |||
| - `[*]` [**BREAKING**] TypeScript definitions requires a minimum of TypeScript v3.8 ([#9823](https://github.com/facebook/jest/pull/9823)) | |||
| - `[*]` [**BREAKING**] Drop support for Node 8 ([#9423](https://github.com/facebook/jest/pull/9423)) | |||
| - `[*]` Upgrade to chalk@4 ([#9752](https://github.com/facebook/jest/pull/9752)) | |||
| - `[*]` Remove usage of `realpath-native` | |||
|
Thanks @thymikee! |
jeysal
added a commit
to jeysal/jest
that referenced
this pull request
May 2, 2020
…hile-running * upstream/master: (331 commits) chore: update ts-eslint (jestjs#9953) Updated config docs with default transform value (jestjs#8583) Update jest-phabricator documentation (jestjs#8662) chore: remove dependency on `realpath-native` (jestjs#9952) chore: bump dated dependencies (jestjs#9951) chore: another try at fixing test-utils dependency chore: update lockfile due to beta release chore: move changelog entry and fix tets utils dependency Fix time duration formatting as per SI (jestjs#9765) v26.0.0-alpha.0 chore: run some jsdom tests in leak check (jestjs#9938) chore: upgrade chalk to v4 (jestjs#9752) feat: upgrade to JSDOM 16 (jestjs#9606) chore: remove checks for compileFunction (jestjs#9949) chore: drop node 8 support (jestjs#9423) Remove leftover `providesModuleNodeModules` (jestjs#9948) [BREAKING] Pojer -> Nakazawa chore: revert lockfile changes from 2b32fe6 chore: move changelog entry and fix lint Remove `providesModuleNodeModules` from Jest. (jestjs#9583) ...
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We don't need it anymore as node 10 has
realpathSync.nativeTest plan
Green CI