-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jest-resolve - wrap realpath with try catch block #8292
jest-resolve - wrap realpath with try catch block #8292
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Codecov Report
@@ Coverage Diff @@
## master #8292 +/- ##
==========================================
+ Coverage 63.85% 63.85% +<.01%
==========================================
Files 274 274
Lines 11389 11390 +1
Branches 2771 2770 -1
==========================================
+ Hits 7272 7273 +1
Misses 3498 3498
Partials 619 619
Continue to review full report at Codecov.
|
Looks like the snapshots are still off, could you rebase it once again to the latest master? |
@thymikee, I updated snapshots, could please take one more look? One check which is failing seems not related to my changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Can you add a changelog entry?
@thymikee, updated changelog, does it looks correct? |
@thymikee, thanks for review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but if I understand @SimenB's comment in #8291 correctly, the preferred solution would be to only change it in SimenB/realpath-native#39?
Correct, but the problem is that the owners of realpath may not be really interested in this change. Three months have passed, but it doesn't seem to be getting anywhere. Here is another possible solution that may probably work in this case: |
@SimenB rebased, this should be good to review again |
Can we close this then? |
Should be fixed with the above linked PR |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Fixes #8291
Test plan
Minor changes in snapshots