-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(jest-types): correct type testRegex for ProjectConfig #9780
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9780 +/- ##
=========================================
Coverage ? 64.91%
=========================================
Files ? 288
Lines ? 12203
Branches ? 3026
=========================================
Hits ? 7922
Misses ? 3641
Partials ? 640
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
FYI, using tuple type |
…pshots * upstream/master: (225 commits) docs: add CLA link to contributing docs (jestjs#9789) chore: roll new version of docs v25.3.0 chore: update changelog for release chore(jest-types): correct type testRegex for ProjectConfig (jestjs#9780) feat(circus): enable writing async test event handlers (jestjs#9397) feat: enable all babel syntax plugins (jestjs#9774) chore: add helper for getting Jest's config in e2e tests (jestjs#9770) feat: pass ESM options to transformers (jestjs#9597) chore: replace `any`s with `unknown`s (jestjs#9626) feat: pass ESM options to Babel (jestjs#9766) chore(website): add copy button the code blocks (jestjs#9750) chore: bump istanbul-reports for new uncovered lines design (jestjs#9758) chore: correct CHANGELOG.md (jestjs#9763) chore(jest-types): expose type `CacheKeyOptions` for `getCacheK… (jestjs#9762) docs: Fix simple typo, seperated -> separated (jestjs#9760) v25.2.7 chore: update changelog for release fix: drop getters and setters when diffing objects for error (jestjs#9757) chore(jest-types): correct return type of shouldRunTestSuite fo… (jestjs#9753) ...
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Type of
testRegex
inProjectConfig
doesn't match with documentation and also not match with real capable value. It should bestring | string[] | RegExp[]
. This PR does 2 things:Array<RegExp>
to the existing type oftestRegex
inProjectConfig
.Array<RegExp>
fortestRegex
in Configuration page.I'm not entirely sure if
testRegex
inProjectConfig
can be string or not, but the documentation says it can be string as well. For now I just updated the type to addArray<RegExp>
to the existing type. I observed that addingstring
will change quite something in internal codes so I won't touch.Test plan
Green CI probably ?