Reduce singleton #3164
Merged
Reduce singleton #3164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Support custom platforms on jest-haste-map * Run prettier
|
This is great. It's ironic how we took a single file build of Jasmine, pretty-printed it and now we are turning it back into a set of modules. |
skovhus
pushed a commit
to skovhus/jest
that referenced
this pull request
Apr 29, 2017
* [jest-jasmine2] Split `jasmine-light` over multiple files. * Don't wrap things that don't need to be wrapped. * Don't wrap things that don't need to be wrapped (again). * Lint. * [jest-jasmine2] Trim `jasmine` singleton. * Adding NHL to companies that use Jest (jestjs#3163) * Support custom platforms on jest-haste-map (jestjs#3162) * Support custom platforms on jest-haste-map * Run prettier * Rebase.
tushardhole
pushed a commit
to tushardhole/jest
that referenced
this pull request
Aug 21, 2017
* [jest-jasmine2] Split `jasmine-light` over multiple files. * Don't wrap things that don't need to be wrapped. * Don't wrap things that don't need to be wrapped (again). * Lint. * [jest-jasmine2] Trim `jasmine` singleton. * Adding NHL to companies that use Jest (jestjs#3163) * Support custom platforms on jest-haste-map (jestjs#3162) * Support custom platforms on jest-haste-map * Run prettier * Rebase.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Builds on #3159.
Reduces the usage of the
j$singleton and removes properties that are not used/not supported (CallTracker,SpyStrategy,isSpy,createSpyObject). It's not technically breaking, since they don't seem to have been documented, but I might want to be cautious.Test plan
All existing tests should pass.